Update live to 0.39.0 #86

cristiangreco · 2022-09-08T17:42:40Z

No description provided.

This commit resolves nerdswords#365. In cases in which the name of the dimensions for a given metric didn't match a dimension in our searchTags list, we would pass a default global query for all metrics under a given namespace into our list, returning metrics we meant to filter. A test case was added to cover. In addition, I decorated a debug log entry that was useful in finding this bug.

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.47 to 1.44.57. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.44.47...v1.44.57) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…es/github.com/aws/aws-sdk-go-1.44.57 Bump github.com/aws/aws-sdk-go from 1.44.47 to 1.44.57

Fix DX metrics DimensionRegexps

…x-search-tags Fix searchTags and bad dimension name

…rrors fix lint errors

…trics Add AWS Elemental MediaTailor support

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.57 to 1.44.87. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.44.57...v1.44.87) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.10.3 to 2.11.2. - [Release notes](https://github.com/urfave/cli/releases) - [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md) - [Commits](urfave/cli@v2.10.3...v2.11.2) --- updated-dependencies: - dependency-name: github.com/urfave/cli/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Services: support storagegateway metrics * Support tags for GatewayName only storagegateway metrics Such as SmbV3Sessions

…e ARN (nerdswords#631)

* Added prometheus-yace-exporter chart * Fix for IRSA not working and remove unused clusterrole and clusterrolebinding.yaml * Pushed version, added new support for IRSA * add custom pod labels/annotations * update README.MD * Fix targetPort on serviceMonitor and make configurable * Make serviceAccount metadata configurable * Fix missing brackets * Make serviceAccount.name propagate to helm chart template * New version * Patch add extraArgs for container startup * Pushed Chart version * NO-TICKET fix indentation * Pushed new version for yace-exporter, more info in mogaal/helm-charts#13 * improve extra args insertion * Update values.yaml * Use tpl function to create config.yml configmap Signed-off-by: Elliot Kennedy <me@elken.io> * Push version to include changes of mogaal/helm-charts#14 and mogaal/helm-charts#15 * Fix custom service account name * flag provided but not defined: -scrape-interval flag provided but not defined: -scrape-interval Usage of yace: -scraping-interval int Seconds to wait between scraping the AWS metrics if decoupled scraping. (default 300) * Push version - merged new PRs * move to charts dir * rename dir * rename variables names * update helm (#3) * Update helm * Add pipeline * Minor fixes * New helm (#5) * fix values readme deployment * Add helm to README.md * Update release.yml * helm publish works only on push to master * fix nindent * fix servicemonitor * add charts dir to dockerignore Signed-off-by: Elliot Kennedy <me@elken.io> Co-authored-by: Alejandro Garrido Mota <garridomota@gmail.com> Co-authored-by: larsbenedetto <lbenedetto@toogoodtogo.com> Co-authored-by: Michal Jancek <michal_jancek@swissre.com> Co-authored-by: Jason Witkowski <jwitko1@gmail.com> Co-authored-by: Victor Daskalov <victor.daskalov@hyperscience.com> Co-authored-by: ilyes ajroud <ilyes.ajroud@gmail.com> Co-authored-by: Elliot Kennedy <me@elken.io> Co-authored-by: Thomas Peitz <thomas.peitz@nerdswords.de> Co-authored-by: Alexei Eremin <haru.eaa@gmail.com>

…words#636) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.2 to 1.13.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.12.2...v1.13.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This has been failing since [0]: when the dimension name is wrong then metric should be filtered out. [0] nerdswords#642

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.87 to 1.44.93. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.44.87...v1.44.93) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…es/github.com/aws/aws-sdk-go-1.44.93 Bump github.com/aws/aws-sdk-go from 1.44.87 to 1.44.93

Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.11.2 to 2.14.1. - [Release notes](https://github.com/urfave/cli/releases) - [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md) - [Commits](urfave/cli@v2.11.2...v2.14.1) --- updated-dependencies: - dependency-name: github.com/urfave/cli/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…es/github.com/urfave/cli/v2-2.14.1 Bump github.com/urfave/cli/v2 from 2.11.2 to 2.14.1

CLAassistant · 2022-09-08T17:42:48Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 9 committers have signed the CLA.

✅ cristiangreco
❌ Scott McCracken
❌ paulojmdias
❌ femiagbabiaka
❌ ch4rms
❌ vkobets
❌ sedan07
❌ thomaspeitz
❌ mtt88

Scott McCracken seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

kgeckhart

👍 anything of note for us? I scanned the changelog + changes and didn't see anything standout.

Also, I adjusted the default merge policy to be rebase + merge which should keep live and master from diverging due to merge/squash commits.

Unused since decoupled scraping became the default mode.

…words#657) Run the actual validation in the action before logging success.

cristiangreco · 2022-09-12T09:21:14Z

👍 anything of note for us? I scanned the changelog + changes and didn't see anything standout.

No nothing too relevant, although might require some adjustment for the session interface.

I'm going to PR disabling the new workflow for the helm chart.

femiagbabiaka and others added 28 commits July 13, 2022 18:06

Merge pull request nerdswords#622 from nerdswords/dependabot/go_modul…

5a60227

…es/github.com/aws/aws-sdk-go-1.44.57 Bump github.com/aws/aws-sdk-go from 1.44.47 to 1.44.57

Rewrite comments, condense tests.

a8faaf9

Add MediaTailor support

9d54404

update readme

2c6567e

Fix DX metrics DimensionRegexps

49e7d70

Merge pull request nerdswords#638 from paulojmdias/master

8276462

Fix DX metrics DimensionRegexps

Merge pull request nerdswords#621 from femiagbabiaka/femiagbabiaka/fi…

624b183

…x-search-tags Fix searchTags and bad dimension name

Fix file is not gofmt-ed.

41c55c8

Stop using deprecated ioutil package.

c324acf

Merge pull request nerdswords#644 from nerdswords/cristian/fix-lint-e…

713d1b9

…rrors fix lint errors

Merge pull request nerdswords#634 from scott-mccracken/mediatailor-me…

87eeb15

…trics Add AWS Elemental MediaTailor support

Handle empty list in filter metric tests (nerdswords#642)

72713f2

Services: support storagegateway metrics (nerdswords#632)

a8d6331

* Services: support storagegateway metrics * Support tags for GatewayName only storagegateway metrics Such as SmbV3Sessions

Filter api gateway resources so that it does not use the stages in th…

695e6e1

…e ARN (nerdswords#631)

Add info that chart is merged but not released yet

a2c25f3

Fix failing test for the case of empty metric data. (nerdswords#654)

84e7bc7

This has been failing since [0]: when the dimension name is wrong then metric should be filtered out. [0] nerdswords#642

Improve release of helm chart

758b7d0

Merge pull request nerdswords#655 from nerdswords/dependabot/go_modul…

b53ddbd

…es/github.com/aws/aws-sdk-go-1.44.93 Bump github.com/aws/aws-sdk-go from 1.44.87 to 1.44.93

Merge pull request nerdswords#653 from nerdswords/dependabot/go_modul…

ab5ab3a

…es/github.com/urfave/cli/v2-2.14.1 Bump github.com/urfave/cli/v2 from 2.11.2 to 2.14.1

Release 0.39.0-alpha

27db5d9

cristiangreco requested a review from kgeckhart September 8, 2022 17:45

kgeckhart approved these changes Sep 8, 2022

View reviewed changes

cristiangreco added 2 commits September 9, 2022 18:14

main.go: remove unused maxJobLength (nerdswords#656)

5b37cb2

Unused since decoupled scraping became the default mode.

Subcommand verify-config actually validates the config file. (nerds…

629ca67

…words#657) Run the actual validation in the action before logging success.

cristiangreco force-pushed the master branch from 6083188 to 629ca67 Compare September 12, 2022 08:39

cristiangreco merged commit def8ae0 into live Sep 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update live to 0.39.0 #86

Update live to 0.39.0 #86

cristiangreco commented Sep 8, 2022

CLAassistant commented Sep 8, 2022 •

edited

kgeckhart left a comment •

edited

cristiangreco commented Sep 12, 2022

Update live to 0.39.0 #86

Update live to 0.39.0 #86

Conversation

cristiangreco commented Sep 8, 2022

CLAassistant commented Sep 8, 2022 • edited

kgeckhart left a comment • edited

Choose a reason for hiding this comment

cristiangreco commented Sep 12, 2022

CLAassistant commented Sep 8, 2022 •

edited

kgeckhart left a comment •

edited