Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v0.40.0-alpha #97

Closed
wants to merge 48 commits into from
Closed

Merge v0.40.0-alpha #97

wants to merge 48 commits into from

Conversation

cristiangreco
Copy link

No description provided.

femiagbabiaka and others added 30 commits July 13, 2022 18:06
@femiagbabiaka
Fix searchTags and bad dimension name
1d85f70 
This commit resolves nerdswords#365.

In cases in which the name of the dimensions for a given metric didn't
match a dimension in our searchTags list, we would pass a default global query
for all metrics under a given namespace into our list, returning metrics
we meant to filter. A test case was added to cover.

In addition, I decorated a debug log entry that was useful in finding
this bug.
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.47 to 1.44.57
bb74c54 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.47 to 1.44.57.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.44.47...v1.44.57)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@cristiangreco
Merge pull request nerdswords#622 from nerdswords/dependabot/go_modul…
5a60227 
…es/github.com/aws/aws-sdk-go-1.44.57

Bump github.com/aws/aws-sdk-go from 1.44.47 to 1.44.57
@femiagbabiaka
Rewrite comments, condense tests.
a8faaf9
Add MediaTailor support
9d54404
update readme
2c6567e
Fix DX metrics DimensionRegexps
49e7d70
@cristiangreco
Merge pull request nerdswords#638 from paulojmdias/master
8276462 
Fix DX metrics DimensionRegexps
@cristiangreco
Merge pull request nerdswords#621 from femiagbabiaka/femiagbabiaka/fi…
624b183 
…x-search-tags

Fix searchTags and bad dimension name
@cristiangreco
Fix file is not gofmt-ed.
41c55c8
@cristiangreco
Stop using deprecated ioutil package.
c324acf
@cristiangreco
Merge pull request nerdswords#644 from nerdswords/cristian/fix-lint-e…
713d1b9 
…rrors

fix lint errors
@cristiangreco
Merge pull request nerdswords#634 from scott-mccracken/mediatailor-me…
87eeb15 
…trics

Add AWS Elemental MediaTailor support
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.57 to 1.44.87 (nerdswords#646)
bb6317a 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.57 to 1.44.87.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.44.57...v1.44.87)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mtt88
Handle empty list in filter metric tests (nerdswords#642)
72713f2
@dependabot
Bump github.com/urfave/cli/v2 from 2.10.3 to 2.11.2 (nerdswords#640)
a0465a5 
Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.10.3 to 2.11.2.
- [Release notes](https://github.com/urfave/cli/releases)
- [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md)
- [Commits](urfave/cli@v2.10.3...v2.11.2)

---
updated-dependencies:
- dependency-name: github.com/urfave/cli/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sedan07
Services: support storagegateway metrics (nerdswords#632)
a8d6331 
* Services: support storagegateway metrics

* Support tags for GatewayName only storagegateway metrics

Such as SmbV3Sessions
@ch4rms
Filter api gateway resources so that it does not use the stages in th…
695e6e1 
…e ARN (nerdswords#631)
@vkobets @mogaal
@lbenedetto @jwitko @v1ctorrhs @ilyesAj @elliotkennedy @thomaspeitz @haru-mamburu
Add helm chart (nerdswords#610)
5d512af 
* Added prometheus-yace-exporter chart

* Fix for IRSA not working and remove unused clusterrole and clusterrolebinding.yaml

* Pushed version, added new support for IRSA

* add custom pod labels/annotations

* update README.MD

* Fix targetPort on serviceMonitor and make configurable

* Make serviceAccount metadata configurable

* Fix missing brackets

* Make serviceAccount.name propagate to helm chart template

* New version

* Patch add extraArgs for container startup

* Pushed Chart version

* NO-TICKET fix indentation

* Pushed new version for yace-exporter, more info in mogaal/helm-charts#13

* improve extra args insertion

* Update values.yaml

* Use tpl function to create config.yml configmap

Signed-off-by: Elliot Kennedy <me@elken.io>

* Push version to include changes of mogaal/helm-charts#14 and mogaal/helm-charts#15

* Fix custom service account name

* flag provided but not defined: -scrape-interval

flag provided but not defined: -scrape-interval
Usage of yace:
  -scraping-interval int
        Seconds to wait between scraping the AWS metrics if decoupled scraping. (default 300)

* Push version - merged new PRs

* move to charts dir

* rename dir

* rename variables names

* update helm (#3)

* Update helm
* Add pipeline
* Minor fixes

* New helm (#5)

* fix values readme deployment

* Add helm to README.md

* Update release.yml

* helm publish works only on push to master

* fix nindent

* fix servicemonitor

* add charts dir to dockerignore

Signed-off-by: Elliot Kennedy <me@elken.io>
Co-authored-by: Alejandro Garrido Mota <garridomota@gmail.com>
Co-authored-by: larsbenedetto <lbenedetto@toogoodtogo.com>
Co-authored-by: Michal Jancek <michal_jancek@swissre.com>
Co-authored-by: Jason Witkowski <jwitko1@gmail.com>
Co-authored-by: Victor Daskalov <victor.daskalov@hyperscience.com>
Co-authored-by: ilyes ajroud <ilyes.ajroud@gmail.com>
Co-authored-by: Elliot Kennedy <me@elken.io>
Co-authored-by: Thomas Peitz <thomas.peitz@nerdswords.de>
Co-authored-by: Alexei Eremin <haru.eaa@gmail.com>
@dependabot
Bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0 (nerds…
671a9cf 
…words#636)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.2 to 1.13.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.12.2...v1.13.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@thomaspeitz
Add info that chart is merged but not released yet
a2c25f3
@cristiangreco
Fix failing test for the case of empty metric data. (nerdswords#654)
84e7bc7 
This has been failing since [0]: when the dimension name is wrong then
metric should be filtered out.

[0] nerdswords#642
@thomaspeitz
Improve release of helm chart
758b7d0
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.87 to 1.44.93
ab07a66 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.87 to 1.44.93.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.44.87...v1.44.93)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@cristiangreco
Merge pull request nerdswords#655 from nerdswords/dependabot/go_modul…
b53ddbd 
…es/github.com/aws/aws-sdk-go-1.44.93

Bump github.com/aws/aws-sdk-go from 1.44.87 to 1.44.93
@dependabot
Bump github.com/urfave/cli/v2 from 2.11.2 to 2.14.1
e406b35 
Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.11.2 to 2.14.1.
- [Release notes](https://github.com/urfave/cli/releases)
- [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md)
- [Commits](urfave/cli@v2.11.2...v2.14.1)

---
updated-dependencies:
- dependency-name: github.com/urfave/cli/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@cristiangreco
Merge pull request nerdswords#653 from nerdswords/dependabot/go_modul…
ab5ab3a 
…es/github.com/urfave/cli/v2-2.14.1

Bump github.com/urfave/cli/v2 from 2.11.2 to 2.14.1
@thomaspeitz
Release 0.39.0-alpha
27db5d9
@cristiangreco
main.go: remove unused maxJobLength (nerdswords#656)
5b37cb2 
Unused since decoupled scraping became the default mode.
@cristiangreco
Subcommand verify-config actually validates the config file. (nerds…
629ca67 
…words#657)

Run the actual validation in the action before logging success.
yasharne and others added 18 commits September 12, 2022 14:18
@yasharne
fix a typo in Charts.yml
1de4204
@dependabot
Bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0
d2fa264 
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](sirupsen/logrus@v1.8.1...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/sirupsen/logrus
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump actions/setup-python from 2 to 4
0021dac 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v4)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@cristiangreco
Merge pull request nerdswords#658 from yasharne/patch-1
bd246d8 
fix a typo in Charts.yml
@cristiangreco
Merge pull request nerdswords#624 from nerdswords/dependabot/go_modul…
86bd815 
…es/github.com/sirupsen/logrus-1.9.0

Bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0
@dependabot
Bump github.com/urfave/cli/v2 from 2.14.1 to 2.16.3
4394270 
Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.14.1 to 2.16.3.
- [Release notes](https://github.com/urfave/cli/releases)
- [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md)
- [Commits](urfave/cli@v2.14.1...v2.16.3)

---
updated-dependencies:
- dependency-name: github.com/urfave/cli/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.93 to 1.44.96
1da90bd 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.93 to 1.44.96.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.44.93...v1.44.96)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@cristiangreco
Merge pull request nerdswords#650 from nerdswords/dependabot/github_a…
5e2b973 
…ctions/actions/setup-python-4

Bump actions/setup-python from 2 to 4
@cristiangreco
Add dimensions regex for AmazonMQ.
aacb324 
This should fix an issue with AmazonMQ when using `searchTags` which
makes unwanted metrics being included in the scrape even though the
corresponding resource was filtered out due to `searchTags` constraints.

Due to the current implementation, ideally all services should have
regexs defined. I'll followup with further PRs for those services that
need be updated.

Fixes nerdswords#643
@cristiangreco
Merge pull request nerdswords#663 from nerdswords/cristian/mq-dimensi…
97c758d 
…on-regex

Add dimensions regex for AmazonMQ.
@cristiangreco
Fix metrics with additional dimensions being not being scraped.
c75045b 
This partially reverts nerdswords#621, in order to fix an issue with metrics that
have additional dimensions (i.e. more than just what is captured by
dimension regexps). An example is EFS StorageBytes, which comes with
both FileSystemId and StorageClass.

Fixes nerdswords#661
@cristiangreco
Merge pull request nerdswords#664 from nerdswords/cristian/bugfix-efs…
6ccaab0 
…-storagebytes

Fix metrics with additional dimensions being not being scraped.
@cristiangreco
Add test for RemoveDuplicateMetrics.
c3951e9
@cristiangreco
Merge pull request nerdswords#665 from nerdswords/cristian/prom-test
b6ef114 
Add test for RemoveDuplicateMetrics.
@cristiangreco
Merge pull request nerdswords#659 from nerdswords/dependabot/go_modul…
5299801 
…es/github.com/urfave/cli/v2-2.16.3

Bump github.com/urfave/cli/v2 from 2.14.1 to 2.16.3
@cristiangreco
Merge pull request nerdswords#660 from nerdswords/dependabot/go_modul…
4931477 
…es/github.com/aws/aws-sdk-go-1.44.96

Bump github.com/aws/aws-sdk-go from 1.44.93 to 1.44.96
@cristiangreco
Prepare changelog for v0.40.0-alpha
8cf9ec2
@cristiangreco
Merge pull request nerdswords#666 from nerdswords/cristian/release-v0…
3e94b69 
….40.0

Prepare changelog for v0.40.0-alpha
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2022 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 10 committers have signed the CLA.

✅ cristiangreco
❌ Scott McCracken
❌ paulojmdias
❌ sedan07
❌ mtt88
❌ ch4rms
❌ vkobets
❌ thomaspeitz
❌ yasharne
❌ femiagbabiaka

Scott McCracken seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@cristiangreco @CLAassistant @femiagbabiaka @mtt88 @sedan07 @ch4rms @vkobets @thomaspeitz @yasharne