-
Notifications
You must be signed in to change notification settings - Fork 112
InputMaker select field #25
Comments
I have just madea pull request for this - #36 |
My problem with this being an issue is that it's solving a problem with bad data designs not code. It's modifying the code to service a rare situation. How would the user know the difference between A and A when selecting? If either of you guys can give me a reasonable use case I'm happy to merge in the PR. |
I've had issues previously where customers have added new entries into a table with the same name as a previous entry. When those items need to be selected in a drop down i find it useful to show the duplicate so the customer realises they have duplicates in their data. I can see that it is a bad data design but it can happen in the real world. |
Oh I'm happy to merge like I said I just don't want it forcing it on relationships. :) |
Because Laracogs use as label the array key and as value the array value, you could have some issue when you try to fill the options with a query on a table where there are more labels with the same values.
Eg.
(Id, name)
0, "A"
1, "B"
2, "A"
You will get from a query converted in array the follow result
["B"=>1,"A"=>2]
I think that the values should be unique over the labels.
The text was updated successfully, but these errors were encountered: