CLOSED-CAPTIONS quoted-string string fixup #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value can be either a quoted-string or an enumerated-string with the value NONE. If the value is a quoted-string, it MUST match the value of the GROUP-ID attribute of an EXT-X-MEDIA tag elsewhere in the Playlist whose TYPE attribute is CLOSED-CAPTIONS, and indicates the set of closed-caption Renditions that can be used when playing the presentation.
bradleyfalzon
requested changes
Mar 8, 2017
writer_test.go
Outdated
| @@ -572,10 +572,18 @@ func TestNewMasterPlaylistWithClosedCaptionEqNone(t *testing.T) { | |||
| } | |||
| m.Append(fmt.Sprintf("eng_rendition_rendition.m3u8"), p, *vp) | |||
|
|
|||
| expected := `CLOSED-CAPTIONS="NONE"` | |||
| expected := `CLOSED-CAPTIONS=NONE` | |||
There was a problem hiding this comment.
nit: could just be double quotes now.
writer_test.go
Outdated
| m2.Append(fmt.Sprintf("eng_rendition_rendition.m3u8"), p, *vp) | ||
| expected = `CLOSED-CAPTIONS="CC1"` | ||
| if !strings.Contains(m2.String(), expected) { | ||
| t.Fatalf("Master playlist did not contain: %s, \nMaster Playlist: \n%v", expected, m2.String()) |
There was a problem hiding this comment.
I'd reformat this to remove the trailing spaces Master playlist did not contain: %s\nMaster Playlist:\n%v
bradleyfalzon
approved these changes
Mar 8, 2017
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the value NONE. If the value is a quoted-string, it MUST
match the value of the GROUP-ID attribute of an EXT-X-MEDIA tag
elsewhere in the Playlist whose TYPE attribute is CLOSED-CAPTIONS,
and indicates the set of closed-caption Renditions that can be
used when playing the presentation.
Hi I'm very sorry I missed this in spec that when the value is none it should not use quoted strings.