Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoNight Waltz support for CNv0 #223

Closed
bitkis opened this issue Feb 1, 2019 · 18 comments
Closed

CryptoNight Waltz support for CNv0 #223

bitkis opened this issue Feb 1, 2019 · 18 comments

Comments

@bitkis
Copy link
Contributor

bitkis commented Feb 1, 2019

CryptoNight Waltz support for CNv0 needs to be added and tested.

Development team has limited exposure to mining realities right now and believes that active miners are better suited to select the algorithm. We will rely on the miner community to select and test the algorithm (with veto voting power to prevent manipulations.)

For more details see #216

@SomethingGettingWrong

This comment was marked as abuse.

@SomethingGettingWrong

This comment was marked as abuse.

@bitkis
Copy link
Contributor Author

bitkis commented Feb 5, 2019

@Patrickdurbin

NO NICEHASH ATTACKS

Could you please elaborate a bit? In particular, what will prevent Nicehash from implementing CN-GPU in 1-2 month from now?

@SomethingGettingWrong

This comment was marked as abuse.

@jagerman
Copy link
Contributor

jagerman commented Feb 5, 2019

In particular, what will prevent Nicehash from implementing CN-GPU in 1-2 month from now?

There is absolutely nothing that you can do to prevent NiceHash from creating a market for a given coin, but that isn't the issue or even the objective. The issue is that we don't want GRAFT to be vulnerable to 51% attacks that are made easy and cheap via NiceHash, which means either:

  1. The algorithm isn't on NiceHash at all
  2. The algorithm is on NiceHash but has significantly less hashrate readily available than is mining on the network

Option 2 is actually the better option here: NiceHash does provide a useful tool to allow mining by people without their own mining hardware.

Option 1, however, is more likely: it isn't worth NiceHash's time to add an algorithm that only two small coins (GRAFT and RYO) are using. The CN-heavy market has never been a big success, and the CN-light, CN-haven, CN-Masari algorithms never made it to NiceHash at all because, although there are multiple coins on each of them, there just isn't enough hashrate on those coins overall to make it worthwhile. NiceHash is only interested in pursuing big fish, and Graft isn't a big fish.

If the GRFT price and hashrate explode and NiceHash decides to open a CN-GPU market, then good: we'll be in option 2 — NiceHash supplements the network hashrate without allowing overwhelming it, which is the ideal place to be.

@bitkis
Copy link
Contributor Author

bitkis commented Feb 5, 2019

@jagerman,

There is absolutely nothing that you can do to prevent NiceHash from creating a market for a given coin [...]

Can't agree more. And for this exact reason we want to consider it thoroughly before investing significant engineering time into the merge and, especially, testing. So far, I found somewhat different opinions here: Cryptonight variant 4 aka CryptonightR. A quote:

@tevador
[...]
Regarding "CN-GPU", it replaces the AES encryption in the initialization loop with keccak and then the main loop is replaced with just a lot of floating point math (single precision multiplication and addition). That's why it's power hungry. It will be most likely compute-bound on CPUs and possibly also on some GPUs.

It seems no-one knows how exactly it behaves. I doubt we have luxury of running into at least a week of development/testing without further investigation. What do you guys think?

@SomethingGettingWrong

This comment was marked as abuse.

@SomethingGettingWrong

This comment was marked as abuse.

@sebseb7
Copy link

sebseb7 commented Feb 14, 2019

@SomethingGettingWrong

This comment was marked as abuse.

@EDDragonWolf
Copy link
Contributor

https://github.com/swap-dev/swap/tree/master/src/crypto/cuckaroo

@sebseb7 not clear what you mean with it. If it's your proposal for new PoW, thanks, but we would like to get more information about it, cryptographical analysis, stats, comparison with other algorithms. Simple link submitting means nothing. And more likely, we won't spend time investigating it.

HA! you got that working? when is your mainnet fork?

@Patrickdurbin, if you asked the Graft Core Team, then no. However, we glad that @sebseb7 (or anyone else) tries to propose something, even if these proposals won't use in the development.

@bobbieltd
Copy link

It is Cuckaroo (from Grin coin’s PoW), hot in cryptoworld, implemented by Seb for CN coins.
Very good idea to consider for Graft.

@SomethingGettingWrong

This comment was marked as abuse.

@sebseb7
Copy link

sebseb7 commented Feb 19, 2019

but we would like to get more information about it, cryptographical analysis, stats, comparison with other algorithms.

read the whitepaper: https://github.com/tromp/cuckoo/blob/master/doc/cuckoo.pdf

@sebseb7
Copy link

sebseb7 commented Feb 19, 2019

but the problem is that it is and on Nicehash already

only grins personal variant of it available on nicehash. Not my variant or other variants.

@sebseb7
Copy link

sebseb7 commented Feb 19, 2019

I proposed Cn-gpu

floating point for consensous? not a good idea!

http://www.yosoygames.com.ar/wp/2013/07/on-floating-point-determinism/

@randygrolemund
Copy link

I came up with a solution to prevent 51% attacks, but I could not get people to use my product, so I shut it down. You will have the same problems, over and over, as long as you allow 1 pool to hold more than 50% of the traffic. Your currency, like so many others, fails in that regard. Not only do you need to worry about the algo... you also need a way to prevent everyone from bunching up on the same server.
Look here: https://miningpoolstats.stream/graft Here is PANDA (hit space bar 2x to start it): https://www.profitbotpro.com/panda/assets/player/KeynoteDHTMLPlayer.html

@EDDragonWolf
Copy link
Contributor

@randygrolemund, thanks. We'll look at it. However, not for this fork, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants