Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added player inventory, block placement #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zhuowei
Copy link
Contributor

@zhuowei zhuowei commented Apr 15, 2011

(also a /give command)

@grahamedgecombe
Copy link
Owner

Is it necessary to store an array of SlottedItems in the inventory? That kind of ends up duplicating the slot number and also makes it harder to move items around (with the Item class, you can pass the objects around without needing to worry about the slot).

The SlottedItem class was originally intended to be simply used for passing items to the codecs in the Message objects.

@zhuowei
Copy link
Contributor Author

zhuowei commented May 12, 2011

I could change it to use Item objects. Also, Glowstone now have a different inventory implementation, which may be better than my version.

@grahamedgecombe
Copy link
Owner

hmm I'll see if I can take a look at the Glowstone version at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants