Update the example to use go-app v9 in place of v6 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v9 is very different from v6, apparently. The following changes were necessary: * Update the dependency to go-app v9. * Update the go compiler to 1.20.5, since go-app v9 needs go 1.18+ * This in turn required new `rules_go`. * This in turn required updating `gazeller`, and protobufs. * Ran `bazel run //:buildifier` to fix the build files. * Unified the server and client side binaries for the sample app. v9 seems to not like when the two are separated. * Moved all static web resources to `/web/...`. This is a requirement in v9, you can not serve these resources from a different subdirectory. * Removed one last(?) appearance of `protoc` string in `api.proto`, which caused `gazelle` and `go mod tidy` to get confused. * Ran `./third_party/update_go_mods`. Most deps got updated to newer versions. * Ran `bazel run //:gazelle` * Migrated some of the v6 API that no longer exists to v9. * Added an icon. Apparently without it, the app will not start (?!) * Renamed SearchBar, InstanceTable and Manager component variables to exported, because it now makes a difference for computing the UI updates. * Fix for a somewhat unusual v9 behavior where a component initialized outside of `OnMount` or `app.RouteFunc` actually does *not* get used in building widgets. Leads to bizarre nil pointer accesses. I added comments that explain where the caveats are.
filmil
force-pushed
the
update-to-goapp-v9
branch
from
c41d66a
to
359a30f
Compare
|
@grahamjenson the v6->v9 migration issues are fixed, you can now merge if you want. |
|
Any interest in merging this? @grahamjenson |
|
Didn't review very closely. Merged with trust :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*issues are now fixed, thanks to the kind folks at maxence-charriere/go-app#853
v9 is very different from v6, apparently.
The following changes were necessary:
rules_go.gazeller, and protobufs.bazel run //:buildifierto fix the build files.seems to not like when the two are separated.
/web/.... This is a requirement inv9, you can not serve these resources from a different subdirectory.
protocstring inapi.proto,which caused
gazelleandgo mod tidyto get confused../third_party/update_go_mods. Most deps got updated to newerversions.
bazel run //:gazelleexported, because it now makes a difference for computing the UI
updates.
outside of
OnMountorapp.RouteFuncactually does not get usedin building widgets. Leads to bizarre nil pointer accesses. I added
comments that explain where the caveats are.