Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create invalid files #19

Open
nicolaslara opened this issue Jul 9, 2013 · 1 comment
Open

Don't create invalid files #19

nicolaslara opened this issue Jul 9, 2013 · 1 comment

Comments

@nicolaslara
Copy link

When running ./kip add something the gpg command might fail (Invalid keys, or whatever). If it does, kip creates an empty file, tries to decrypt it (which obviously fail), and return a stack trace.

Ideally, if the GPG command fails (or returns an empty string), the file would never be created and an error message will be shown. Another option is that, if decryption fails, the file is considered corrupt and deleted.

@grahamking
Copy link
Owner

Ah, that sounds similar to #17

I agree we need friendlier wrapping of gnupg. It's confusing enough to most people, we shouldn't make things worse with stack traces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants