Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unix.IoctlGetWinsize instead of direct system call #26

Closed
jcharum opened this issue Oct 2, 2020 · 1 comment
Closed

Use unix.IoctlGetWinsize instead of direct system call #26

jcharum opened this issue Oct 2, 2020 · 1 comment

Comments

@jcharum
Copy link
Contributor

jcharum commented Oct 2, 2020

In the status package, we make a system call to get the terminal window size.

As of Go 1.12, Go uses libSystem to make system calls. unix.SYS_IOCTL no longer exists as of this commit.

I think that system call should be replaced with a call to unix.IoctlGetWinsize.
@jcharum jcharum mentioned this issue Oct 2, 2020
Merged
@jcharum
Copy link
Contributor Author

jcharum commented Jan 8, 2021

This was fixed as part of #22.

@jcharum jcharum closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcharum