Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to fix build errors with recent versions #22

Merged
merged 4 commits into from
Oct 8, 2020

Conversation

matthewloring
Copy link
Contributor

@matthewloring matthewloring commented Sep 25, 2020

No description provided.

@jcharum
Copy link
Contributor

jcharum commented Sep 30, 2020

Hi @matthewloring! Thanks for the PR. I'm looking into the CI build failures. At least one of them is because we pushed internal changes that are no longer 1.12 compatible, so I will do something about that. I haven't yet had a chance to look into 1.13 build failures but will get to it today (though I'd welcome help understanding them!). Thanks again.

@matthewloring
Copy link
Contributor Author

Thanks for taking a look @jcharum! Unfortunately, env GO111MODULE=on go test -tags=unit ./... passes for me locally so I'm not able to reproduce the 1.13 failures. error: grail-access.test: /home/travis/.v23 is not a directory looks like a vanadium issue, I can take a look tomorrow.

@jcharum
Copy link
Contributor

jcharum commented Oct 1, 2020

@matthewloring : We're having a look internally, so don't worry too much about it. I know very little about Vanadium, though, so I'm enlisting in some other folks in GRAIL. You might be able to reproduce by removing $HOME/.v23 and then trying to run the test. If we can't resolve tomorrow, we might be okay merging over the broken build, but I'd like to avoid that if possible. Thanks!

@matthewloring
Copy link
Contributor Author

@jcharum I don't seem to have a $HOME/.v23 directory locally and the tests still pass locally after creating it.

@jcharum
Copy link
Contributor

jcharum commented Oct 1, 2020

@matthewloring: Thanks for checking. I've chased down the various build problems. They boil down to these things:

Could you merge master to make sure that everything is copacetic? Thanks!

status/term.go Outdated Show resolved Hide resolved
eventlog/cloudwatch/cloudwatch.go Show resolved Hide resolved
@jcharum
Copy link
Contributor

jcharum commented Oct 2, 2020

Yay; builds passed.

@matthewloring
Copy link
Contributor Author

Thank you for fixing the other build breakages!

@jcharum jcharum merged commit 39a424c into grailbio:master Oct 8, 2020
@matthewloring matthewloring deleted the matt-deps branch October 8, 2020 18:46
@matthewloring
Copy link
Contributor Author

Thanks for your help! Will you be able to do a new release of grailbio/base?

@jcharum
Copy link
Contributor

jcharum commented Oct 8, 2020

Thanks for your help! Will you be able to do a new release of grailbio/base?

Thank you for the PR! I'm looking through the changes now, so it should be done shortly.

@jcharum
Copy link
Contributor

jcharum commented Oct 8, 2020

Thanks for your help! Will you be able to do a new release of grailbio/base?

Done: https://github.com/grailbio/base/releases/tag/v0.0.10.

@matthewloring
Copy link
Contributor Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants