-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies to fix build errors with recent versions #22
Conversation
51f7b8c
to
2556bf1
Compare
Hi @matthewloring! Thanks for the PR. I'm looking into the CI build failures. At least one of them is because we pushed internal changes that are no longer 1.12 compatible, so I will do something about that. I haven't yet had a chance to look into 1.13 build failures but will get to it today (though I'd welcome help understanding them!). Thanks again. |
Thanks for taking a look @jcharum! Unfortunately, |
@matthewloring : We're having a look internally, so don't worry too much about it. I know very little about Vanadium, though, so I'm enlisting in some other folks in GRAIL. You might be able to reproduce by removing |
@jcharum I don't seem to have a |
@matthewloring: Thanks for checking. I've chased down the various build problems. They boil down to these things:
Could you merge |
Yay; builds passed. |
Thank you for fixing the other build breakages! |
Use IoctlGetWinsize to get term dimensions
Thanks for your help! Will you be able to do a new release of |
Thank you for the PR! I'm looking through the changes now, so it should be done shortly. |
Done: https://github.com/grailbio/base/releases/tag/v0.0.10. |
Thanks!! |
No description provided.