Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file/s3file: add reference to public issue #37

Merged
merged 1 commit into from
Nov 9, 2022
Merged

file/s3file: add reference to public issue #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions file/s3file/file_chunk_read.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ func (r *chunkReaderAt) ReadAt(ctx context.Context, dst []byte, offset int64) (i
// In rare cases the S3 SDK returns EOF for chunks that are not actually at EOF.
// To work around this, we ignore EOF errors, and keep reading as long as the
// object metadata size field says we're not done. See BXDS-2220 for details.
// See also: https://github.com/aws/aws-sdk-go/issues/4510
default:
if !policy.shouldRetry(ctx, err, r.name) {
break attemptLoop
Expand Down