Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pop!_OS 20.04 #62

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Support Pop!_OS 20.04 #62

merged 3 commits into from
Oct 9, 2020

Conversation

yagehu
Copy link
Contributor

@yagehu yagehu commented Sep 18, 2020

No description provided.

@yagehu
Copy link
Contributor Author

yagehu commented Oct 9, 2020

@siddharthab Can you take a quick look? This simply adds support for Pop OS 20.04. It also fixes a small undefined name bug.

@siddharthab
Copy link
Contributor

Sorry, this got neglected by me.

@siddharthab siddharthab merged commit 9b0bae6 into bazel-contrib:master Oct 9, 2020
@zaucy zaucy mentioned this pull request Jun 2, 2022
siddharthab pushed a commit that referenced this pull request Jun 2, 2022
Pop!_OS support was broken for me as I am currently running 22.04.

#62 seemed to mix Pop!_OS with Linux Mint and specific version checks, but AFAIK Pop!_OS uses the same version as Ubuntu. This change simply treats Pop!_OS as Ubuntu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants