ec2system: change handling of default ec2boot binaries #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding ec2boot in the config (which materializes to, e.g., $HOME/.bigslice/config), we set the default to an empty string, and fill in the default binary associated with the current release. We also rewrite binaries with the official prefix to match the current version.
jcharum
suggested changes
Nov 13, 2019
Co-Authored-By: jcharum <jcharumilind@grailbio.com>
Co-Authored-By: jcharum <jcharumilind@grailbio.com>
|
Any idea if/how the build failure is related? |
No, don't think so: this error seems to pop up regularly on Travis-CI. |
jcharum
approved these changes
Nov 13, 2019
|
@jcharum: Somehow these changes do not appear to made it into |
|
@jcharum: figured it out. since this was based on |
mariusae
added a commit
that referenced
this pull request
Nov 13, 2019
Instead of hardcoding ec2boot in the config (which materializes to, e.g., $HOME/.bigslice/config), we set the default to an empty string, and fill in the default binary associated with the current release. We also rewrite binaries with the official prefix to match the current version.
|
Repaired by #19. |
jcharum
pushed a commit
that referenced
this pull request
Nov 13, 2019
Instead of hardcoding ec2boot in the config (which materializes to, e.g., $HOME/.bigslice/config), we set the default to an empty string, and fill in the default binary associated with the current release. We also rewrite binaries with the official prefix to match the current version.
|
Sorry I missed that. I'll make sure to double-check that next time. Were we supposed to have rebased #18 onto master? It seems nonobvious in the UI how to do that, but I'll work it out next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding ec2boot in the config (which materializes to, e.g., $HOME/.bigslice/config), we set the default to an empty string, and fill in the default binary associated with the current release.
We also rewrite binaries with the official prefix to match the current version.