Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Error - connectionFactory should be connectionfactory #13

Merged
merged 1 commit into from Jun 25, 2013

Conversation

tomaslin
Copy link
Contributor

In the documentation describing exchanges, the DSL reads:

rabbitmq {
    connectionFactory {
        ...
    }
    queues = {
        exchange name: 'my.topic', type: topic
    }
}

Note the capital F in factory.

When running this, the application shows an error:

[localhost-startStop-1] ERROR RabbitmqGrailsPlugin  - RabbitMQ connection factory settings (rabbitmq.connectionfactory.username, rabbitmq.connectionfactory.password and rabbitmq.connectionfactory.hostname) must be defined in Config.groovy

The attached patch fixes this error in the documentation.

@pledbrook
Copy link
Member

I would prefer to leave the documentation as it is and allow for a connectionFactory setting as well as connectionfactory. The latter is unexpected in a world of camel-case. The disadvantage of such an approach is that it requires a new release of the plugin whereas a documentation change does not.

@stesteau
Copy link

7 months later, the conclusion is neither ;p

graemerocher added a commit that referenced this pull request Jun 25, 2013
Documentation Error - connectionFactory should be connectionfactory
@graemerocher graemerocher merged commit aec4c66 into grails-plugins:master Jun 25, 2013
selamialtin pushed a commit to selamialtin/grails-rabbitmq that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants