move logic from controller to service

grails-samples · Jun 20, 2012 · 76e2568 · 76e2568
1 parent 80cfa68
commit 76e2568
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 27 deletions.
diff --git a/grails-app/controllers/org/grails/twitter/StatusController.groovy b/grails-app/controllers/org/grails/twitter/StatusController.groovy
@@ -7,18 +7,16 @@ import org.grails.twitter.auth.Person
 @Secured('IS_AUTHENTICATED_FULLY')
 class StatusController {
 
-    def springSecurityService
     def statusService
-    def twitterCache
 
     def index() {
-        def messages = currentUserTimeline()
+        def messages = statusService.currentUserTimeline()
         [statusMessages: messages]
     }
 
     def updateStatus(String message) {
         statusService.updateStatus message
-        def messages = currentUserTimeline()
+        def messages = statusService.currentUserTimeline()
 
         def content = twitter.renderMessages messages: messages
         render content
@@ -28,27 +26,4 @@ class StatusController {
         statusService.follow id
         redirect action: 'index'
     }
-
-    private lookupPerson() {
-        Person.get(springSecurityService.principal.id)
-    }
-
-    private currentUserTimeline() {
-        def messages = twitterCache[springSecurityService.principal.username]
-        if (!messages) {
-            log.debug "No messages found in cache for user <${springSecurityService.principal.username}>. Querying database..."
-            def per = lookupPerson()
-            def query = Status.whereAny {
-                author { username == per.username }
-                if(per.followed) author in per.followed
-            }.order 'dateCreated', 'desc'
-            messages = query.list(max: 10)
-
-            twitterCache[springSecurityService.principal.username] = messages
-        }
-        else {
-            log.debug "Status messages loaded from cache for user <${springSecurityService.principal.username}>."
-        }
-        messages
-    }
 }
diff --git a/grails-app/services/org/grails/twitter/StatusService.groovy b/grails-app/services/org/grails/twitter/StatusService.groovy
@@ -38,6 +38,25 @@ class StatusService {
         }
     }
 
+    def currentUserTimeline() {
+        def messages = twitterCache[springSecurityService.principal.username]
+        if (!messages) {
+            log.debug "No messages found in cache for user <${springSecurityService.principal.username}>. Querying database..."
+            def per = lookupPerson()
+            def query = Status.whereAny {
+                author { username == per.username }
+                if(per.followed) author in per.followed
+            }.order 'dateCreated', 'desc'
+            messages = query.list(max: 10)
+
+            twitterCache[springSecurityService.principal.username] = messages
+        }
+        else {
+            log.debug "Status messages loaded from cache for user <${springSecurityService.principal.username}>."
+        }
+        messages
+    }
+
     private lookupPerson() {
         Person.get(springSecurityService.principal.id)
     }