GRAILS-8415 - Add subscript operator support to commandObject.errors

grails · Dec 2, 2011 · b96e68b · b96e68b
1 parent 84aa865
commit b96e68b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/...g/codehaus/groovy/grails/compiler/web/ControllerActionTransformerCommandObjectSpec.groovy b/...g/codehaus/groovy/grails/compiler/web/ControllerActionTransformerCommandObjectSpec.groovy
@@ -275,6 +275,17 @@ class ControllerActionTransformerCommandObjectSpec extends Specification {
             model.person.theAnswer == 42
     }
 
+    void 'Test subscript operator on command object errors'() {
+        when:
+            testController.params.name = 'Maynard'
+            def model = testController.closureAction()
+
+        then:
+            model.person.hasErrors()
+            model.person.name == 'Maynard'
+            'matches.invalid.name' in model.person.errors['name'].codes
+    }
+
     void "Test validation"() {
         when:
             testController.params.name = 'JFK'

diff --git a/...n/src/main/groovy/org/codehaus/groovy/grails/web/plugins/support/ValidationSupport.groovy b/...n/src/main/groovy/org/codehaus/groovy/grails/web/plugins/support/ValidationSupport.groovy
@@ -15,11 +15,9 @@
  */
 package org.codehaus.groovy.grails.web.plugins.support
 
-import org.codehaus.groovy.grails.validation.ConstraintsEvaluator
-import org.codehaus.groovy.grails.validation.DefaultConstraintEvaluator
+import grails.validation.ValidationErrors
+
 import org.codehaus.groovy.grails.web.context.ServletContextHolder
-import org.springframework.validation.BeanPropertyBindingResult
-import org.springframework.web.context.ContextLoader
 import org.springframework.web.context.support.WebApplicationContextUtils
 
 
@@ -41,7 +39,7 @@ class ValidationSupport {
             }
 
             def messageSource = ctx?.containsBean('messageSource') ? ctx.getBean('messageSource') : null
-            def localErrors = new BeanPropertyBindingResult(object, object.class.name)
+            def localErrors = new ValidationErrors(object, object.class.name)
             def originalErrors = object.errors
             for(originalError in originalErrors.allErrors) {
                 if(originalErrors.getFieldError(originalError.field)?.bindingFailure) {