Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to have custom build.gradle in custom profiles #11019

Open
2 tasks done
smakela opened this issue Jun 5, 2018 · 1 comment
Open
2 tasks done

Way to have custom build.gradle in custom profiles #11019

smakela opened this issue Jun 5, 2018 · 1 comment
Labels
type: enhancement New feature or request

Comments

@smakela
Copy link

smakela commented Jun 5, 2018

Thanks for reporting an issue for Grails framework, please review the task list below before submitting the
issue. Your issue report will be closed if the issue is incomplete and the below tasks not completed.

NOTE: If you are unsure about something and the issue is more of a question a better place to ask questions is on Stack Overflow (http://stackoverflow.com/tags/grails) or Slack (http://slack-signup.grails.org). DO NOT use the issue tracker to ask questions.

Task List

  • Steps to reproduce provided
  • [] Stacktrace (if present) provided
  • [] Example that reproduces the problem uploaded to Github
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. Create custom profile with custom build.gradle that extends for example "plugin" -profile
  2. Create for example plugin with the custom profile

Expected Behaviour

I would like to have custom build.gradle in my profile that extends another profile.

For example if I extend "base" and "plugin" -profiles then the "plugin" -pfofiles build.gradle is concatenated with "base" -profiles build.gradle and then my profiles build.gradle is concatenated to that result. I would like to just have my own build.gradle with no concatenation.

It would be nice to use the feature that already exists, but it does not work for the build.gradle because there is custom code for handling those.

https://github.com/grails/grails-core/blob/master/grails-shell/src/main/groovy/org/grails/cli/profile/commands/CreateAppCommand.groovy

skeleton:
    excludes:
        - build.gradle

I have not checked but mayby this same behaviour is true also for application.yml

Actual Behaviour

build.gradle files are now concatenated and there is no way to just have custom build.gradle in my profile.

@smakela
Copy link
Author

smakela commented Nov 13, 2018

@ilopmar I provided a pull request for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants