Decouple Sitemesh - Step 2 #13118
Merged
Decouple Sitemesh - Step 2 #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayoutFinder for referencing attributes.
…g/grails/web/sitemesh due to it being required by GSPResponseWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1:
GrailsRoutablePrintWriter needs to be moved in a non-breaking way so that GSPResponseWriter doesn't depend on grails-web-sitemesh.
In order to do this in a non breaking way without circular dependencies, this class should be moved to the grails-encoder package.
A subsequent release of grails-gsp can then remove the class after GSPResponseWriter is updated to depend on the new package.
Change 2:
GrailsLayoutDecoratorMapper has 3 constants that are simply redundant references to GroovyPageLayoutFinder. The references should be updated directly to GroovyPageLayoutFinder so that both classes are not required when trying to resolve the value.
The reason for referencing them in GroovyPageLayoutFinder instead of moving them into GrailsLayoutDecoratorMapper is because GroovyPageLayoutFinder can not be removed from ResponseRenderer.groovy without breaking plugins that have previously compiled controllers using an earlier version of this trait.