chore: update url to HTTPS #13478
Merged
chore: update url to HTTPS #13478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to HTTPS url in the Apache License and other places.
matrei
reviewed
Apr 22, 2024
| } catch (Exception e) { | ||
| // ignore, parser doesn't support | ||
| } | ||
| try { | ||
| saxParserFactory.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false); | ||
| saxParserFactory.setFeature("https://apache.org/xml/features/nonvalidating/load-external-dtd", false); |
There was a problem hiding this comment.
@puneetbehl I don't think these strings should be changed. Aren't they keywords for turning on/off features of the parser?
|
@puneetbehl Also, should the urls in the Apache license text really be changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to HTTPS url in the Apache License and other places.