Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for upgrading to Grails 4.1 #757

Merged
merged 5 commits into from May 20, 2020
Merged

Conversation

puneetbehl
Copy link
Contributor

No description provided.


Grails 4.1 provide support for Groovy 3. We would recommend you to please check the https://groovy-lang.org/releasenotes/groovy-3.0.html[Release notes for Groovy 3] to update your application in case you are using a specific feature which might not work in Groovy 3.

Define groovyVersion in `gradle.properties` to force the application to use Groovy 3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? Why would I need to "force" my app to use groovy 3 if grails 4.1 is using groovy 3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erichelgeson Basically the groovy-all nonsense and conflicting transitive dependencies. Setting the property just sets up the resolution strategy to force the supplied version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could Grails set the default? (eg for 4.1.0 its 3.0.3, but for 4.1.2 it could be 3.0.5) - the common use case would be to take the grails defaults, the uncommon would be to override manually. Feels awkward to require the user to set it.


### Deprecation of dot navigation of Grails configuration

In order to reduce complexity, improve performance, and increase maintainability, accessing configuration through dot notation (config.a.b.c) has been deprecated. This functionality will be removed in a future release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been in Grails for a long time and removing to reduce complexity at the expense of requiring all apps to change seems counter-intuitive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobbywarner Applications should have changed a long time ago when the getProperty methods were introduced. This is deprecated, so there will be plenty of time for folks to migrate.

@jameskleeh jameskleeh merged commit 9c1899c into master May 20, 2020
@jameskleeh jameskleeh deleted the upgrading branch May 20, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants