Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x branch changes need to be merged into develop #431

Closed
longwa opened this issue Apr 2, 2020 · 2 comments · Fixed by #432
Closed

2.x branch changes need to be merged into develop #431

longwa opened this issue Apr 2, 2020 · 2 comments · Fixed by #432
Milestone
3.0.1

Comments

@longwa
Copy link
Contributor

longwa commented Apr 2, 2020

There are changes in 2.x, specifically some fixes for:

https://github.com/alvarosanchez/grails-spring-security-rest/pull/402/commits

That are not present in the more current release. I believe this branch was never merged into develop branch.

Unless, we merge, several issues will be re-introduced including the ability to use a refresh token as an access token indefinitely (since they don't expire by default).
@longwa longwa changed the title 2.x branch changes need to be merged into 3.x 2.x branch changes need to be merged into develop Apr 2, 2020
@longwa
Copy link
Contributor Author

longwa commented Apr 2, 2020

PR: #432

alvarosanchez added a commit that referenced this issue Apr 6, 2020
@alvarosanchez
Merge pull request #432 from longwa/develop
a266d18 
Issue #431, merge changes from 2.x branch
@alvarosanchez alvarosanchez linked a pull request Apr 6, 2020 that will close this issue
Issue #431, merge changes from 2.x branch #432
Merged
@alvarosanchez
Copy link
Member

Good catch! I've merged it and will release 3.0.1

@alvarosanchez alvarosanchez added this to the 3.0.1 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

Issue #431, merge changes from 2.x branch longwa/grails-spring-security-rest
2 participants
@alvarosanchez @longwa