Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failing Facebook test as credentials need to be updated #349

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Ignore failing Facebook test as credentials need to be updated #349

merged 1 commit into from
Sep 14, 2017

Conversation

bobbywarner
Copy link
Contributor

@bobbywarner bobbywarner commented Sep 14, 2017

The FacebookSpec is currently failing on Travis CI because I believe the Facebook credentials being used are no longer valid. So, opening this PR to ignore the test so that a new SNAPSHOT can be published with this fix: #348

This should obviously be reverted after the Facebook credentials are updated. The useFacebook system property must not be enabled for pull requests.

@alvarosanchez alvarosanchez merged commit d91c751 into grails:develop Sep 14, 2017
@alvarosanchez
Copy link
Member

Thanks for catching it. I will take care of that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants