Fixing configuration setting name for jwt secret key #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think |
|
oh, my bad, you are right. I just based it on an issue I found online,
because my own code was not compiling, just fixed it again... you are good
that you caught it :)
…On Thu, Jun 13, 2019 at 1:38 PM Álvaro Sánchez-Mariscal < ***@***.***> wrote:
Thanks for the PR.
I think conf is indeed a mistake, but the grails. prefix certainly not.
What led you to think the prefix needs to be removed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#398>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPDIHTKIGVBHAAW5FMKXGLP2IPSVANCNFSM4HXYAP3A>
.
|
|
No problem, that's what PR reviews are for. Thanks for your contribution! |
|
Thank you! I think this was my first open source contribution ever :)
…On Fri, Jun 14, 2019 at 12:17 PM Álvaro Sánchez-Mariscal < ***@***.***> wrote:
Merged #398
<#398>
into develop.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#398>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPDIHUFUP4N4DTM2NHPD5LP2NO3HANCNFSM4HXYAP3A>
.
|
|
Congrats, and keep going! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.