Issue 43: email i18n files #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Modified forgot password email to be internationalized by now rendering it with a gsp that utilizes `messages.properties` • modified email from config text to be more friendly. It is now 'Do Not Reply <do.not.reply@localhost>' • modified subject line retrieval to pass an array to `getMessage` instead of a List • fixed bug where html was being escaped in email body • sending of verification email using gsps has been implemented • for backwards compatibility, if the user has overridden the body in the config, the text from the config will be used in registration email • modified forgot password email logic to support using the email body as defined in the config it it exists, otherwise it will use gsps • fixed broken tests
…ded first from `DefaultUiSecurityConfig` and, if it doesn't exist in config, then it will be loaded from `messages.properties`. this was done to ensure backwards compatibility
… it exists (for legacy support) else it will load from `messages.properties` • wrote a test
… it exists (for legacy support) else it will load from `messages.properties` • wrote a test
…when a type of `register` is targeted • modified documentation to reflect the additional templates and layout now beign copied when targeting `register` override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve issue #43