Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Upgrade to libbinaryen v110 #173

Merged
merged 19 commits into from Jan 12, 2023
Merged

feat!: Upgrade to libbinaryen v110 #173

merged 19 commits into from Jan 12, 2023

Conversation

phated
Copy link
Member

@phated phated commented Jan 10, 2023

This upgrades libbinaryen to v110 and adapts the bindings for the changes upstream.

I separated each thing into their own commits so it will be easier for @ospencer to review.

@phated phated requested a review from ospencer January 10, 2023 01:00
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good, just one thought on the load functions.

Up to you if you want to make the changes but it's fine either way.

Great work!

src/binaryen_stubs_expressions.js Show resolved Hide resolved
@phated
Copy link
Member Author

phated commented Jan 10, 2023

Updated, but waiting on ocaml/opam-repository#22863 to be merged so we can release these breaking updates

@phated phated merged commit 474e5cd into master Jan 12, 2023
@phated phated deleted the phated/libbinaryen-110 branch January 12, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants