Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package libbinaryen.110.0.0 #22863

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

grainbot
Copy link
Contributor

@grainbot grainbot commented Jan 6, 2023

libbinaryen.110.0.0

Libbinaryen packaged for OCaml



110.0.0 (2023-01-05)

⚠ BREAKING CHANGES

  • Require dune 3.0 to better support js_of_ocaml
  • Require js_of_ocaml 4.1 to ensure optimization fix
  • Update binaryen to version_110 (#72)

Features

Miscellaneous Chores

  • Require dune 3.0 to better support js_of_ocaml (008d8ff)
  • Require js_of_ocaml 4.1 to ensure optimization fix (008d8ff)

🐫 Pull-request generated by opam-publish v2.0.3

@phated
Copy link
Contributor

phated commented Jan 10, 2023

@mseri Can we get this merged so we can submit our updated bindings?

@mseri
Copy link
Member

mseri commented Jan 11, 2023

Does binaryen_dsl.0.7 require an upper bound on this release? (and maybe dune although I don't get the failure):

#=== ERROR while compiling binaryen_dsl.0.7 ===================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/binaryen_dsl.0.7
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p binaryen_dsl -j 31
# exit-code            1
# env-file             ~/.opam/log/binaryen_dsl-7-5a0aef.env
# output-file          ~/.opam/log/binaryen_dsl-7-5a0aef.out
### output ###
# (cd _build/default && stub_gen/stub_gen.exe -c)
# gen C
# File "dune", line 7, characters 9-10:
# 7 |   (names b)
#              ^
[...]
# b.c:339:17: error: too few arguments to function 'BinaryenMemoryCopy'
#   339 |    void* x249 = BinaryenMemoryCopy(x245, x246, x247, x248);
#       |                 ^~~~~~~~~~~~~~~~~~
[...]

@phated
Copy link
Contributor

phated commented Jan 11, 2023

Yes, we've discussed that on a different release. I don't think the author kept working on it.

@mseri
Copy link
Member

mseri commented Jan 12, 2023

Do you know what is the bound that I need to add? Is libbinaryen 110, 109, 107? I looked for the discussion in the previous PRs but could not find it

@phated
Copy link
Contributor

phated commented Jan 12, 2023

There are breaking changes every Binaryen release so it would have to be the exact version he depended on, which looks like our first version based on publish dates https://github.com/grain-lang/libbinaryen/releases/tag/v101.0.1

mseri referenced this pull request in mseri/opam-repository Jan 12, 2023
Seen on `https://github.com/ocaml/opam-repository/pull/22863`
Fails with C binding issues

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Copy link
Member

mseri commented Jan 12, 2023

Thanks

@mseri mseri merged commit 7b63242 into ocaml:master Jan 12, 2023
@phated phated deleted the opam-publish-libbinaryen.110.0.0 branch January 12, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants