Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression api updates #102

Merged
merged 22 commits into from May 7, 2021
Merged

Expression api updates #102

merged 22 commits into from May 7, 2021

Conversation

jozanza
Copy link
Contributor

@jozanza jozanza commented Apr 25, 2021

Rip global_get_get_this_bread ☠️

@jozanza
chore: add Expression.Block module
0b50f56
@jozanza
chore: add Expression If and Loop modules
2d726fb
@jozanza
chore: add Expression.Break module
95394d9
@jozanza
chore: add Expression.Switch module
360dcde
@jozanza
chore: add Expression.Call module
ea715f2
@jozanza
chore: add Expression.Call_indirect module
2f42757
@jozanza
chore: add Expression.Local_set module
3e2b5a6
@jozanza
chore: add Expression.Global_get and Expression.Global_set modules
7927a95
@jozanza
chore: add Expression.Memory_grow module
541a120
@jozanza
chore: add Expression.Load module
21f5916
@jozanza
chore: add Expression.Store module
9114a85
@jozanza
chore: add Expression.Unary module
57d421c
@jozanza
chore: add Expression.Binary module
7aebe40
@jozanza
chore: add Expression.Select module
17cec26
@jozanza
chore: add Expression.Drop module
46fb3f2
@jozanza
chore: add Expression.Return module
88f2bbf
@jozanza
chore: add Expression.Memory_copy module
a825250
@jozanza
chore: add Expression.Memory_fill module
e76066a
@jozanza
chore: add Expression.Tuple_make module
0b3668c
@jozanza
chore: add Expression.Tuple_extract module
b62a059
@jozanza
chore: Fix module name typo
508199a
@jozanza
chore: add Expression.Util module
9de0d39
ospencer
ospencer approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! 🎉

@phated I think we should squash this + all of the PRs into a single commit that we merge in (with a proper update to v101). WDYT?

@jozanza jozanza mentioned this pull request Apr 26, 2021
Merged
phated
phated approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just chatted with @ospencer and we're going to merge this into working-dev, then I'm going to apply some nitpicks on top before we get it merged. We're also going to squash away the rename messages because none of those names actually landed yet. Thanks a ton @jozanza!

@phated phated merged commit 09efc78 into grain-lang:working-dev May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@ospencer ospencer ospencer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jozanza @phated @ospencer