Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up compcore.re #1034

Closed
peblair opened this issue Nov 20, 2021 · 2 comments
Closed

Break up compcore.re #1034

peblair opened this issue Nov 20, 2021 · 2 comments

Comments

@peblair
Copy link
Member

peblair commented Nov 20, 2021

compcore.re is ~3500 lines now, and it is responsible for basically all of the mashtree->binaryen compilation logic. Is there a way we can break this up into more manageable chunks? It's not obvious to me where we can carve things up. Where would make the most sense?

cc @ospencer

@ospencer
Copy link
Member

It looks like this is a duplicate of #85 🙂

But yes. We did some work to break it up a bit but it needs a lot more work... Maybe moving the allocation stuff into its own file, grouping some constructs, stuff like functions maybe.

@peblair
Copy link
Member Author

peblair commented Nov 21, 2021

Oops. I'll close this one as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants