Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --experimental-wasm-bigint flag when wasm-bigint is no longer experimental #114

Closed
ospencer opened this issue May 8, 2020 · 4 comments · Fixed by #1092
Closed
Assignees
Labels

Comments

@ospencer
Copy link
Member

ospencer commented May 8, 2020

Once this feature in Node.js is no longer experimental, we can remove this flag.

https://github.com/grain-lang/grain/blob/master/cli/bin/grain.js#L2

@ospencer ospencer self-assigned this May 8, 2020
@phated
Copy link
Member

phated commented May 23, 2020

Just ran into this. We need to specify an engine because I was using node 10 LTS and it failed

@ospencer
Copy link
Member Author

Made #120 to address. I'll probably get around to it tomorrow.

@ospencer
Copy link
Member Author

Node 16 becomes LTS on October 26. I think that's when we should drop support for Node 14 🙂

@phated
Copy link
Member

phated commented Sep 14, 2021

Since that's a breaking change, I don't expect it to happen until our next minor release, which I'm also not expecting to happen in 1.5 months 😛 But, likely in Grain 0.5, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants