Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: Improve FromNumberLiteral warnings. #2019

Closed
spotandjake opened this issue Feb 13, 2024 · 0 comments · Fixed by #2024
Closed

Compiler: Improve FromNumberLiteral warnings. #2019

spotandjake opened this issue Feb 13, 2024 · 0 comments · Fixed by #2024
Labels
compiler

Comments

@spotandjake
Copy link
Member

Currently, we warn if we notice a user trying todo Int64.fromNumber(1) along with the same operation on Float32, Float64, Int32, Int64, Uint32, Uint64. But we have since added more types such as Int8 we should add the same error for consistency and to promote good code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(compiler): Add fromNumber(<literal>) warning for short types spotandjake/grain
1 participant
@spotandjake