Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stdlib): Avoid WASI random_get in Hash stdlib during module startup #2078

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix(stdlib): Avoid WASI random_get in Hash stdlib during module startup #2078

merged 3 commits into from
Mar 28, 2024

Conversation

ospencer
Copy link
Member

No description provided.

@ospencer ospencer self-assigned this Mar 25, 2024
spotandjake
spotandjake requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think we need to add some the exception that could occur to grain doc but otherwise lets get this merged.

stdlib/hash.gr Show resolved Hide resolved
@ospencer
Copy link
Member Author

@spotandjake done.

spotandjake
spotandjake approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@spotandjake
Copy link
Member

It does look like before this gets merged the grain doc is going to need to be regenerated.

marcusroberts
marcusroberts approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ospencer ospencer added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 7eadfb0 Mar 28, 2024
12 checks passed
@ospencer ospencer deleted the oscar/hash-delay-init branch March 28, 2024 21:54
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@spotandjake spotandjake spotandjake approved these changes

@phated phated Awaiting requested review from phated phated is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ospencer @spotandjake @marcusroberts