Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grainlsp): Prevent LSP crash on startup when running in JS #2084

Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix(grainlsp): Prevent LSP crash on startup when running in JS #2084

merged 1 commit into from
Apr 1, 2024

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Apr 1, 2024

No description provided.

@ospencer ospencer self-assigned this Apr 1, 2024
marcusroberts
marcusroberts approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix

@ospencer ospencer enabled auto-merge April 1, 2024 17:15
@ospencer ospencer added this pull request to the merge queue Apr 1, 2024
Merged via the queue into main with commit e99cf1f Apr 1, 2024
12 checks passed
@ospencer ospencer deleted the oscar/fix-lsp-jsoo-hacks branch April 1, 2024 18:53
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@phated phated Awaiting requested review from phated phated is a code owner

@alex-snezhko alex-snezhko Awaiting requested review from alex-snezhko alex-snezhko is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ospencer @marcusroberts