Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update binaryen to version_104 #42

Merged
merged 3 commits into from
Feb 7, 2022
Merged

feat: Update binaryen to version_104 #42

merged 3 commits into from
Feb 7, 2022

Conversation

phated
Copy link
Member

@phated phated commented Jan 24, 2022

I ran into a weird error when I ran the tests the first time:

ld: warning: could not create compact unwind for _caml_start_program: dwarf uses DW_CFA_same_value
ld: warning: could not create compact unwind for _caml_raise_exn: stack subq instruction is too different from dwarf stack size
ld: warning: could not create compact unwind for _caml_raise_exception: stack subq instruction is too different from dwarf stack size

But it never came up again and the smoke test seems to be succeeding.

@phated phated marked this pull request as ready for review February 7, 2022 17:33
@phated phated requested a review from ospencer February 7, 2022 17:33
@phated
Copy link
Member Author

phated commented Feb 7, 2022

Promoting from draft, as I added the flags that make the warnings go away in this PR (they are just copied from binaryen.ml)

@phated phated merged commit 2000604 into main Feb 7, 2022
@phated phated deleted the phated/version_104 branch February 7, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants