Fix unicode issue with SORTKEY on python 2 #34
Conversation
| MetaData(), | ||
| Column('id', Integer, primary_key=True), | ||
| Column('name', String), | ||
| redshift_sortkey=unicode("id")) |
There was a problem hiding this comment.
You can use u'id' and this will work on both
There was a problem hiding this comment.
The lint test runs on python 3 and throws an error for this unicode.
|
+1 |
| @@ -11,6 +11,7 @@ | |||
| from sqlalchemy.ext.compiler import compiles | |||
| from sqlalchemy.sql.expression import Executable, ClauseElement | |||
| from sqlalchemy.types import VARCHAR, NullType | |||
| from sqlalchemy.util.compat import string_types | |||
There was a problem hiding this comment.
When was this added to sqlalchemy? Is it considered public?
There was a problem hiding this comment.
hmm looking at it it's definitely not public. What would be the best way to go about this? If I were to copy over the code, the linter would complain about unicode or basestring
There was a problem hiding this comment.
What about a compat.py with a # noqa line?
bouk
force-pushed
the
check-unicode
branch
3 times, most recently
from
c30d2f6
to
f705281
Compare
|
@graingert how's this look? |
| if py3k: | ||
| string_types = str, | ||
| else: | ||
| string_types = basestring, |
There was a problem hiding this comment.
I prefer parenthesis with my tuples
There was a problem hiding this comment.
can you move the noqa to this line?
There was a problem hiding this comment.
Me too, I just copied the sa style. fixed
|
Looks good to me, have a look at the fixes then update the issue name, changelog, squash etc |
bouk
changed the title
bouk
changed the title
bouk
changed the title
|
done |
Fix unicode issue with SORTKEY on python 2
Fix unicode issue with SORTKEY on python 2
This is to make sure unicode is supported in python2
@graingert