Bugfix for java.lang.RuntimeException: Couldn’t get PID of Grakn. Received ' #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolski
changed the title
marco-scoppetta
approved these changes
May 24, 2018
|
what could go wrong? |
kasper-piskorski
suggested changes
May 24, 2018
|
|
||
| String pidString = outputS.toString().trim(); | ||
| String[] pidAndHostnameString = ManagementFactory.getRuntimeMXBean().getName().split("@"); | ||
| String pidString = pidAndHostnameString[0]; |
There was a problem hiding this comment.
Do we know how portability is affected? isn't the name platform-specific? That's what the RuntimeMXBean spec says.
There was a problem hiding this comment.
@kasper-piskorski There exists no platform-independent way that can be guaranteed to work in all jvm implementations. ManagementFactory.getRuntimeMXBean().getName() looks like the best (closest) solution. It's short, and probably works in every implementation in wide use.
On linux+windows it returns a value like 12345@hostname (12345 being the process id).
kasper-piskorski
approved these changes
May 24, 2018
marco-scoppetta
pushed a commit
that referenced
this pull request
May 25, 2018
* fix gc launcher link and add extra comment (#2794) * Removes uses of "<role_name> sub role" in docs examples, moving to "as" syntax (#2785) Explicitly defining role hierarchies is deprecated, in favour of using the "as" keyword in a "relates" statement within a relationship. * Bugfix for java.lang.RuntimeException: Couldn’t get PID of Grakn. Received ' (#2815) * get pid using mxbean * Engine should still start if there is a dangling /tmp/grakn-engine.pid file but there's no process anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Addresses issue #2811
What does the PR do?
ps -ef | grepwithManagementFactory.getRuntimeMXBean().getName()Does it break backwards compatibility?
No
List of future improvements not on this PR
N/A