Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add findbugs maven plugin #973

Merged
merged 42 commits into from
Jan 19, 2017
Merged

Add findbugs maven plugin #973

merged 42 commits into from
Jan 19, 2017

Conversation

aelred
Copy link
Contributor

@aelred aelred commented Jan 18, 2017 •
edited
Loading

  • This plugin runs during the verify stage like PMD
  • Detects likely bugs by inspecting the bytecode

Several refactors, including:

  • Replace some mutable objects with immutable ones where appropriate
  • Only mutate static fields in static methods
  • Replace any incorrect "clone" implementations with custom "copy" methods
  • Use explicit encodings instead of assuming the default system encoding
  • Use StringBuilder when building strings in loops
  • Refactor GraqlShell so REPL executes in a single thread (using a queue of server messages)
  • Remove buggy GraqlShell behaviour to intercept SIGINT (that used internal sun classes)
  • Add default cases to all switch statements

aelred and others added 30 commits January 17, 2017 09:52
@aelred @fppt
Add basic findbugs configuration
0e6474d
@aelred @fppt
Refactor code to pass findbugs
9aaf562
@aelred @fppt
Replace Cloneable interface with copy method
3821de6
@aelred @fppt
Fix bug with using static date format
491720f
@aelred @fppt
Use StringBuilder instead of concatenating String
8618d8a
@aelred @fppt
Replace keySet iteration with entrySet
5281635
@aelred @fppt
Remove redundant guava dependencies
4b4dc2b
@aelred @fppt
Fix findbugs issue with unused return value
b3b4dfd
@aelred @fppt
Fix mistake with AtomicQuery#equals
e625740
@aelred @fppt
Add implementation of abstract method
63e53b8
@aelred @fppt
Use Instant instead of Date in tasks
4ca11cf
@aelred @fppt
Use %n instead of \n in format string
80df893
@aelred @fppt
Make sure FileInputStream instances are always closed
2ea5539
@aelred @fppt
Make sure a lock is released
6533c41
@aelred @fppt
Don't do unnecessary unboxing
765a72e
@aelred @fppt
Add default switch case
7b1592d
@aelred @fppt
Use string builder for string concatenation in a loop
024f491
@aelred @fppt
stop TaskState being Serializable
78f7768
@aelred @fppt
Add removeInstance static methods
d331059
@aelred @fppt
Handle null cases
4361249
@aelred @fppt
Add default case to switch statement
c44fc2e
@aelred @fppt
Convert Json to String correctly
1b3f212
@fppt
Fixes after rebase
6bb532c
@fppt
Fix minor issue in graql components
62e7dc3
@fppt
Add hashcode method to ReasonerAtomicQuery. Get Kasper to double chec…
e84b228 
…k this definition
@fppt
Resolve bad locking in fctory
f92333e
@fppt
Specify default encoding in SystemKeyspace
877a51b
@fppt
Specify default encoding in EngineCommunicator
2725fe3
@fppt
Add specific encoding to engine
4ab3529
@fppt
Remove synchronisatin from GraknStateSTorage
e356030
fppt and others added 11 commits January 17, 2017 14:06
@fppt
Sort our encoding in graql shell
85b3c26
@aelred
Make COMMAND immutable
82a8cd8
@aelred
Add default to switch case
42ad496
@aelred
Remove Ctrl-C handling code
5ae020a 
This used internal sun classes to operate and didn't work very well.
@aelred
Specify default encoding for stdout
75e9de0
@aelred
Refactor history file creation
be6ea5d
@aelred
Change message handling in graql shell to occur synchronously
ae0c1d1
@aelred
Merge branch 'master'
040bff6 
Conflicts:
	grakn-engine/src/main/java/ai/grakn/engine/session/GraqlSession.java
	grakn-graql/src/main/java/ai/grakn/graql/internal/reasoner/query/ReasonerAtomicQuery.java
	grakn-test/src/test/java/ai/grakn/test/graql/reasoner/AtomicQueryTest.java
@aelred
Add explicit encodings to migration
575eea6
@aelred
Merge
21e01d0
@aelred
Fix bug with mix-up of seconds and milliseconds
e7cc2b3
@codecov-io
Copy link

codecov-io commented Jan 18, 2017 •
edited
Loading

Current coverage is 28.21% (diff: 33.94%)

Merging #973 into master will increase coverage by 0.04%

@@             master       #973   diff @@
==========================================
  Files           235        234     -1   
  Lines          8641       8640     -1   
  Methods           0          0          
  Messages          0          0          
  Branches       1268       1266     -2   
==========================================
+ Hits           2434       2438     +4   
+ Misses         6073       6067     -6   
- Partials        134        135     +1

Powered by Codecov. Last update 06e68c3...f49de6a

@aelred aelred requested a review from fppt January 19, 2017 10:02
@fppt fppt merged commit ef3ed9b into typedb:master Jan 19, 2017
@aelred aelred deleted the findbugs branch January 19, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fppt fppt fppt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelred @codecov-io @fppt