[WIP] Separate relevant parts into their own "mixin" classes / continue adding missing pieces #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least I think so
No major changes
painor
reviewed
Apr 18, 2020
painor
reviewed
Apr 18, 2020
examples/getMe.js
Outdated
| @@ -11,4 +11,5 @@ const { TelegramClient } = require('../gramjs') | |||
| await client.connect() | |||
|
|
|||
| console.log(await client.getMe()) | |||
| await client.disconnect().then(() => process.exit(0)) | |||
There was a problem hiding this comment.
This will make it only work in node environments and not in browsers.
There was a problem hiding this comment.
Fair, I only had Node in mind for that example
|
Good PR. Although I am not familiar with Mixin so I'm going to assume it's just a hack to do multiple inheritances as python does. I'm going to test it more and give some feedbacks. |
|
Yeah it's basically a hack, although one that works pretty well. The standard way to do mixins is to just use |
vrumger
reviewed
Apr 19, 2020
Closed
* Update eslint config * Fix brace-style in eslint config * Fix prefer-const * Lint files
|
I'm closing this in favor of #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is going to be a big one. I just wanted to get it in as a PR so I can get feedback on it as I work. It's nowhere near finished yet, but it is at least testable in many cases. So far it entails two main pieces:
TelegramClientapart into smaller, more manageable pieces. This is inspired by Telethon and handled in a very similar way (which I was surprised is actually very possible with JavaScript).I'm definitely open to comments. Yes, this is basically just a straight port of the way Telethon does things, no I am not creative enough to come up with my own "unique" way of handling things. Telethon just does things very well and I didn't see a reason to diverge too much. So props to Lonami 😄