Checks for llvm versions break on minor version update of llvm

[dvzrv]

Hi! When building faust 2.30.5 I used llvm 11.0.0.
After an upgrade to llvm 11.1.0 a (re)build breaks, because some files rely on overly explicit preprocessor macros: https://github.com/grame-cncm/faust/search?q=LLVM_110

llvm 11.1.0 exposes LLVM_111 instead of LLVM_110 and the build breaks.
Maybe this can be somehow improved by relying on "greater than" comparison or by utilizing the LLVM_VERSION, which exposes the complete version string?

[sletz]

This has been fixed in 5fbe042

[dvzrv]

I don't think so. The above search link still shows e.g. the remaining explicit matches against LLVM_110 (but not LLVM_111).

[sletz]

Build on macOS gives this kind of log: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DCPP_BUILD -DCSHARP_BUILD -DC_BUILD -DDLANG_BUILD -DFIR_BUILD -DINTERP_BUILD -DJAVA_BUILD -DLIBDIR=\"lib\" -DLLVM_110 -DLLVM_BUILD -DLLVM_VERSION=\"11.1.0\" -DOCPP_BUILD -DRUST_BUILD -DSOUL_BUILD -DWASM_BUILD

Building with macports: https://ports.macports.org/port/llvm-11/summary

[dvzrv]

Hm, looking at our build script for llvm, I don't see anything that would suggest our distribution build deliberately choosing LLVM_111 over LLVM_110.

Given that macports applies many more patches than us, it's more likely that exposing LLVM_110 when using llvm 11.1.0 is a bug (but I am not an llvm expert ;-) ).

Besides that, do you think that there's a way of doing conditional checks against the version string in the remaining locations, that do not rely on LLVM_*?

[sletz]

Besides that, do you think that there's a way of doing conditional checks against the version string in the remaining locations, that do not rely on LLVM_*?

What do you mean?

[dvzrv]

To do what is described in the initial ticket text and not rely on LLVM_* (https://github.com/grame-cncm/faust/search?q=LLVM_110) but to make use of LLVM_VERSION instead.

[dvzrv]

@sletz argh, nevermind. I just now realized what that change you mentioned actually does! 🙄

Nevermind the noise!