Fixes to the Stratus architecture file and the faust2stratus script #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch cannot be rebased due to conflicts ==> I always to "rebase merging" to keep the linear tree. You still have tab/space issues in your code and that cause merge conflicts, so:
Thanks ! |
|
Certainly! Can you just clarify - you want tabs in the code, or spaces in the code? |
|
It's probably best to close this PR and do it again, eh :) |
|
only spaces in the code, thanks ! |
|
Yes, a new PR is event better, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The architecture file has been optimized to remove a lot of unnecessary pointer redirections
The script has been fixed to be much tighter about output file naming and location