Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to faustwasm and reorganize #4

Merged
merged 36 commits into from Jul 7, 2023
Merged

Switch to faustwasm and reorganize #4

merged 36 commits into from Jul 7, 2023

Conversation

ijc8
Copy link
Contributor

@ijc8 ijc8 commented Jun 20, 2023

Builds on #3. Instead of checking in copies of faustwasm and faust-ui into this repository, this PR creates package.json and lists them (along with CodeMirror 5, which is already copied on master) as npm dependencies, with the aim of decluttering the repo and simplifying maintenance.

WIP. Remaining tasks:

  • Convert remaining scripts into ES modules so vite build works.
  • Configure GitHub actions so that this will continue to work as a GitHub pages site.
  • Finish testing.
  • Update README with setup & build instructions.

Questions:

@sletz
Copy link
Member

sletz commented Jun 22, 2023

  • https://fausteditor.grame.fr/faustlive-wasm.html is fixed

  • _f4u$t is related to the old SVG based GUI (developed by Mike Solomon in 2013). faust_ui is Shihong new GUI model, developed for Faust IDE. We can discuss if moving from f4u$t to faust_ui can be done in fausteditor also, so that to only use and maintain one GUI model for all projects.

@sletz
Copy link
Member

sletz commented Jun 26, 2023

I understand the package has to be built using npm right ? can you possibly complete the README to explain how to build ? Thanks.

@sletz
Copy link
Member

sletz commented Jun 27, 2023

Testing with npm run dev:

  • configure running mode, polyphonic mode is working
  • but "Save DSP control parameters state" and "Save DSP source" are not woking anymore, seems an issue with local storage ?

And npm run build produces a dist folder with missing CSS ? (ugly display)

ijc8 added 2 commits June 27, 2023 14:55
These are inoperative on `master` because they lack spaces around the
'-' in `calc()`.
@sletz
Copy link
Member

sletz commented Jun 28, 2023

BTW: I guess some files like mixer32.wasm and libfaust-wasm.data (part of faustwasm subproject AFAICS) are not needed in the repository anymore right ?

@ijc8 ijc8 marked this pull request as ready for review July 3, 2023 18:54
@sletz sletz merged commit 7285a83 into grame-cncm:master Jul 7, 2023
@sletz sletz temporarily deployed to github-pages July 7, 2023 14:30 — with GitHub Actions Inactive
@sletz sletz temporarily deployed to github-pages July 7, 2023 14:31 — with GitHub Pages Inactive
@sletz sletz temporarily deployed to github-pages July 7, 2023 14:59 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants