add CZ oscillators #4
Conversation
|
Cool, CZ "phase distortion synthesis" sounds great!
…On Sun, Apr 1, 2018 at 11:12 AM, Bart Brouns ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#4
Commit Summary
- add CZ oscillators
File Changes
- *M* oscillators.lib
<https://github.com/grame-cncm/faustlibraries/pull/4/files#diff-0>
(192)
Patch Links:
- https://github.com/grame-cncm/faustlibraries/pull/4.patch
- https://github.com/grame-cncm/faustlibraries/pull/4.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACGVFVdzK6pHBiTib78NtxiaD5sj-0Hbks5tkRidgaJpZM4TC6xr>
.
--
Julius O. Smith III <jos@ccrma.stanford.edu>
Professor of Music and, by courtesy, Electrical Engineering
CCRMA, Stanford University
http://ccrma.stanford.edu/~jos/ <http://ccrma.stanford.edu/>
|
Yeah, it does! :) BTW, did you get a chance to look at my compressors? |
|
I have not yet seen the compressors. I was waiting until Romain's
integration of your pull request was complete. - Julius
…On Sun, Apr 1, 2018 at 12:21 PM, Bart Brouns ***@***.***> wrote:
Cool, CZ "phase distortion synthesis" sounds great!
Yeah, it does! :)
BTW, did you get a chance to look at my compressors
<#3>?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACGVFdQi_KJHXwtujai_O3CSIjWJAqKvks5tkSiggaJpZM4TC6xr>
.
--
Julius O. Smith III <jos@ccrma.stanford.edu>
Professor of Music and, by courtesy, Electrical Engineering
CCRMA, Stanford University
http://ccrma.stanford.edu/~jos/ <http://ccrma.stanford.edu/>
|
|
I think both Romain and me would like you to have a look at it before I even do a proper pull request.
Also, if you have some time, I'd love to get some feedback on the quality of the code and the algorithms, slidingReduce in particular. |
|
Sure, I am happy to look things over! However, I don't know what context I
am in. I originally asked you to send me your finished proposed version of
compressors.lib (including your own proposed name choices), saying that I
would "deal" (i.e., make a pass) on that. However, that request was
superseded by a request (by Romain) for a pull request (a mechanism I've
never used but am happy to learn more about). I am therefore waiting for
the smoke to clear on that so I can take a look at what you guys both feel
is the Right Thing. All I really want to do is get your final proposed
version of compressors.lib in an Emacs buffer comparing to the existing
version in a second buffer, using compare-windows to see what the
changes/additions are.
Cheers,
- Julius
…On Sun, Apr 1, 2018 at 12:59 PM, Bart Brouns ***@***.***> wrote:
I think both Romain and me would like you to have a look at it before I
even do a proper pull request.
Romain explicitly said:
I'll let you figure out the potential naming conflicts with @josmithiii
<https://github.com/josmithiii>
Also, if you have some time, I'd love to get some feedback on the quality
of the code and the algorithms, slidingReduce in particular.
I'm sure there's a lot for me to learn.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACGVFYgfqilPJ9dcsDRE5n5Rm8-1JIzwks5tkTGggaJpZM4TC6xr>
.
--
Julius O. Smith III <jos@ccrma.stanford.edu>
Professor of Music and, by courtesy, Electrical Engineering
CCRMA, Stanford University
http://ccrma.stanford.edu/~jos/ <http://ccrma.stanford.edu/>
|
|
@rmichon Any news on this? |
|
Sorry for being so slow at this @magnetophon . I was traveling for the past 2 weeks and I'm now at the middle of moving in to Lyon and there are so many things unrelated to Faust I need to take care off these days. Awesome work man! Thanks for all your contributions! I'll update the doc and do a new commit after that. |
|
@magnetophon Ok I just updated the documentation (I created a new section for your CZ functions). For some reasons, some of the LF oscillators were moved to the waveguide oscillators section so I put them back where they belong (this has nothing to do with your push request, of course). |
|
No wories @rmichon, I'm not always quick either! ;) |
No description provided.