Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use faustwasm for compilation #7

Closed
wants to merge 4 commits into from

Conversation

Fr0stbyteR
Copy link
Contributor

Updated Faust Wasm Compiler to faustwasm

May need some more tests.

@sletz
Copy link
Member

sletz commented Jun 12, 2022

Thanks a lot, I'll have a look.

@sletz
Copy link
Member

sletz commented Jun 21, 2022

Working great, but still some issues:

  • ScriptProcessor mode is not working anymore on older Safari versions. I think this is better to keep it for now. Could it be restored?
  • "Precompile" mode is not working anymore. But since this is not implemented in faust2wasm, I suggest we simply drop this feature (which was basically done to speedup loading of big patches, but does not seem mandatory). So we should remove "Small exemple precompile" and "Big exemple precompile" in the "LOAD" menu and the "Precompile (heavier)" checkbox in "SAVE" menu. Can you have a look?
  • and thanks for the great work !

@sletz
Copy link
Member

sletz commented Jun 21, 2022

Another point: the project was built using a makefile which was calling "tsc". It does now create errors. It is still supposed to work? Or another build tool is used?

@Fr0stbyteR
Copy link
Contributor Author

Faustwasm actually do support precompile. I updated the two examples so now they work.
I added the ScriptProcessor compilation, but I don't have a version of Safari without AudioWorklet to test...

@sletz
Copy link
Member

sletz commented Jun 27, 2022

Great thanks ! It works on older Safari version, but still with this message
Capture d’écran 2022-06-27 à 11 13 39
Do you see where it comes from?

@sletz
Copy link
Member

sletz commented Jun 27, 2022

Thanks, but the alert is still there...

@Fr0stbyteR
Copy link
Contributor Author

Not quite sure what happened.. the code is at Main.ts l52, an error should be captured there. Can you check please? @sletz

@sletz
Copy link
Member

sletz commented Jun 27, 2022

Foe some reason Utilitary.audioContext.destination.maxChannelCount = 0 on this old Safari 13.1.2 and this cause the exception that is incorrectly catched as "errorNoWebAudioAPI". This message is already there on "official" FPG, so I guess we can just ignore it and keep the code the way is behaves.

@sletz
Copy link
Member

sletz commented Jul 31, 2023

Was improved with #9 and then merged, thanks!

@sletz sletz closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants