Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synonym search for comicgen characters #35

Closed
wants to merge 1 commit into from
Closed

synonym search for comicgen characters #35

wants to merge 1 commit into from

Conversation

kriti21
Copy link
Collaborator

@kriti21 kriti21 commented Sep 13, 2019 •
edited
Loading

To dos :

  • move synonym.js to docs as json
  • script.js should load synonym.json via ajax
  • dynamically generate urls using file.json
  • separate template to create image panel in index.html (html not in js)
  • one character of each type in a row. mix of characters

@sanand0
Copy link
Contributor

sanand0 commented Sep 14, 2019

@kriti21 I've added a number of review comments to this. Could you please answer those? We can do this over a call if you prefer.

@kriti21
Copy link
Collaborator Author

kriti21 commented Sep 16, 2019

@sanand0 I have made changes to this merge request to remove unnecessary code changes .
Please review it again.

sanand0
sanand0 reviewed Sep 20, 2019
View reviewed changes
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
docs/script.js Outdated Show resolved Hide resolved
docs/script.js Outdated Show resolved Hide resolved
docs/script.js Outdated Show resolved Hide resolved
@sanand0
Copy link
Contributor

sanand0 commented Sep 20, 2019 •
edited
Loading

  • Match only the emotion, not the poses. Otherwise, searching for "angry" also matches the "angryfrustrated" pose with a "happy" emotion
  • Fix eslint errors

@sanand0
Copy link
Contributor

sanand0 commented Sep 24, 2019

Closed via ef77e1b

@sanand0 sanand0 closed this Sep 24, 2019
@sanand0 sanand0 mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanand0 sanand0 sanand0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kriti21 @sanand0