Skip to content

Commit

Permalink
[LibOS] test/regression: reenable sigaltstack test
Browse files Browse the repository at this point in the history
There was a small bug in the test itself, which is fixed (sigaltstack
size must be sufficiently large to hold the Gramine-generated frame).

Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
  • Loading branch information
dimakuv authored and mkow committed Mar 20, 2024
1 parent f10b434 commit 0ee48ee
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 4 additions & 2 deletions libos/test/regression/sigaltstack.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@
#include <string.h>
#include <unistd.h>

/* default SIGSTKSZ is 8KB which is too small to hold e.g. XSAVE area (always stored by Gramine) */
size_t sig_stack_size = 64 * 1024;
uint8_t* sig_stack;
size_t sig_stack_size = SIGSTKSZ;
_Atomic int count = 0;

_Atomic int count = 0;

static void handler(int signal, siginfo_t* info, void* ucontext) {
int ret;
Expand Down
1 change: 0 additions & 1 deletion libos/test/regression/test_libos.py
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,6 @@ def test_05A_munmap(self):
stdout, _ = self.run_binary(['munmap'])
self.assertIn('TEST OK', stdout)

@unittest.skip('sigaltstack isn\'t correctly implemented')
def test_060_sigaltstack(self):
stdout, _ = self.run_binary(['sigaltstack'])

Expand Down

0 comments on commit 0ee48ee

Please sign in to comment.