Fix random issues detected by Coverity tool

This commit doesn't fix any real bugs, but only removes some dead code.

Signed-off-by: jkr0103 <jitender.kumar@intel.com>

common/src/protected_files/protected_files.c

@@ -203,7 +203,6 @@ static void ipf_init_root_mht(file_node_t* mht) {
 static bool ipf_update_all_data_and_mht_nodes(pf_context_t* pf) {
     bool ret = false;
     file_node_t** mht_array = NULL;
-    file_node_t* file_mht_node;
     pf_status_t status;
     void* data = lruc_get_first(pf->cache);
 
@@ -232,8 +231,8 @@ static bool ipf_update_all_data_and_mht_nodes(pf_context_t* pf) {
                     goto out;
                 }
 
-                file_mht_node = data_node->parent;
 #ifdef DEBUG
+                file_node_t* file_mht_node = data_node->parent;
                 // this loop should do nothing, add it here just to be safe
                 while (file_mht_node->node_number != 0) {
                     assert(file_mht_node->need_writing == true);
@@ -268,7 +267,7 @@ static bool ipf_update_all_data_and_mht_nodes(pf_context_t* pf) {
     uint64_t dirty_idx = 0;
     while (data != NULL) {
         if (((file_node_t*)data)->type == FILE_MHT_NODE_TYPE) {
-            file_mht_node = (file_node_t*)data;
+            file_node_t* file_mht_node = (file_node_t*)data;
 
             if (file_mht_node->need_writing)
                 mht_array[dirty_idx++] = file_mht_node;
@@ -282,7 +281,7 @@ static bool ipf_update_all_data_and_mht_nodes(pf_context_t* pf) {
 
     // update the gmacs in the parents from last node to first (bottom layers first)
     for (dirty_idx = dirty_count; dirty_idx > 0; dirty_idx--) {
-        file_mht_node = mht_array[dirty_idx - 1];
+        file_node_t* file_mht_node = mht_array[dirty_idx - 1];
 
         gcm_crypto_data_t* gcm_crypto_data =
             &file_mht_node->parent->decrypted.mht

libos/src/sys/libos_poll.c

@@ -376,7 +376,7 @@ static long do_select(int nfds, struct linux_fd_set* read_set, struct linux_fd_s
 
 long libos_syscall_select(int nfds, struct linux_fd_set* read_set, struct linux_fd_set* write_set,
                           struct linux_fd_set* except_set, struct __kernel_timeval* tv) {
-    if (nfds < 0 || (uint64_t)nfds > get_rlimit_cur(RLIMIT_NOFILE) || nfds > INT_MAX)
+    if (nfds < 0 || (uint64_t)nfds > get_rlimit_cur(RLIMIT_NOFILE))
         return -EINVAL;
 
     /* Each of `read_set`, `write_set` and `except_set` is an array of linux_fd_set items; each
@@ -427,7 +427,7 @@ struct sigset_argpack {
 long libos_syscall_pselect6(int nfds, struct linux_fd_set* read_set, struct linux_fd_set* write_set,
                             struct linux_fd_set* except_set, struct __kernel_timespec* tsp,
                             void* _sigmask_argpack) {
-    if (nfds < 0 || (uint64_t)nfds > get_rlimit_cur(RLIMIT_NOFILE) || nfds > INT_MAX)
+    if (nfds < 0 || (uint64_t)nfds > get_rlimit_cur(RLIMIT_NOFILE))
         return -EINVAL;
 
     /* for explanation on calculations below, see libos_syscall_select() */

pal/src/host/linux/pal_streams.c

@@ -206,10 +206,6 @@ int _PalSendHandle(PAL_HANDLE target_process, PAL_HANDLE cargo) {
     message_hdr.msg_iovlen = 1;
 
     ret = DO_SYSCALL(sendmsg, fd, &message_hdr, 0);
-    if (ret < 0) {
-        free(hdl_data);
-        return unix_to_pal_error(ret);
-    }
 
     free(hdl_data);
     return ret < 0 ? unix_to_pal_error(ret) : 0;

python/graminelibos/gen_jinja_env.py

@@ -91,7 +91,11 @@ def add_globals_misc(env):
     env.globals['ldd'] = ldd
 
 def make_env():
-    env = jinja2.Environment(undefined=jinja2.StrictUndefined, keep_trailing_newline=True)
+
+    # Jinja's autoescape feature escapes HTML sequences but we're rendering TOML, hence explicitly
+    # setting autoescape to False
+    env = jinja2.Environment(undefined=jinja2.StrictUndefined, keep_trailing_newline=True,
+                             autoescape=False)
     add_globals_from_gramine(env)
     add_globals_from_python(env)
     add_globals_misc(env)