Skip to content

Commit

Permalink
[CI] Remove pylint from checks
Browse files Browse the repository at this point in the history
pylint turned out to not be suitable as a CI check due to its
instability between versions and a large amount of questionable
findings.

Signed-off-by: Michał Kowalczyk <mkow@invisiblethingslab.com>
  • Loading branch information
mkow committed Nov 26, 2023
1 parent c2cf7cc commit 85d296c
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
1 change: 0 additions & 1 deletion .ci/lib/stage-lint.jenkinsfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
stage('lint') {
sh '''
./scripts/gitignore-check-files
./.ci/run-pylint -f text
./.ci/run-shellcheck
'''
}
2 changes: 1 addition & 1 deletion .ci/run-shellcheck
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ LC_ALL=C.UTF-8 shellcheck "$@" \
scripts/clean-check-test-copy \
scripts/download \
scripts/gitignore-test \
.ci/run-pylint \
scripts/run-pylint \
.ci/run-shellcheck
1 change: 0 additions & 1 deletion .ci/ubuntu20.04.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ RUN apt-get update && env DEBIAN_FRONTEND=noninteractive apt-get install -y \
pkg-config \
protobuf-c-compiler \
protobuf-compiler \
pylint3 \
python \
python3-apport \
python3-apt \
Expand Down
1 change: 0 additions & 1 deletion .ci/ubuntu22.04.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ RUN apt-get update && env DEBIAN_FRONTEND=noninteractive apt-get install -y \
pkg-config \
protobuf-c-compiler \
protobuf-compiler \
pylint \
python3 \
python3-apport \
python3-apt \
Expand Down
2 changes: 0 additions & 2 deletions libos/test/regression/test_libos.py
Original file line number Diff line number Diff line change
Expand Up @@ -1264,8 +1264,6 @@ def find(self, name, stdout):
return match.group(1).strip()

def test_000_gdb_backtrace(self):
# pylint: disable=fixme
#
# To run this test manually, use:
# GDB=1 GDB_SCRIPT=debug.gdb gramine-{direct|sgx} debug
#
Expand Down
5 changes: 5 additions & 0 deletions .ci/run-pylint → scripts/run-pylint
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/sh

# Currently not used in CI due to a high ratio of questionable findings to meaningful ones and
# incompatible changes between pylint versions.
# It is still recommended to use it and check the results manually when doing bigger changes in
# Python codebase. It's just not suitable as a CI check.

set -e

cd "$(git rev-parse --show-toplevel)"
Expand Down

0 comments on commit 85d296c

Please sign in to comment.