[LibOS] Add post_poll() callback to network sockets
#1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit "[LibOS] Add secure implementation of eventfd" introduced a `post_poll()` callback which can be used to trigger additional events on specific events returned from select/poll/epoll. This commit refactors the LibOS code such that sockets-specific handling of EINPROGRESS is moved from select/poll/epoll code into this `post_poll()` callback. Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
Base automatically changed from
dimakuv/secure-eventfd-single-process
to
master
April 15, 2024 13:41
mkow
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
kailun-qin
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Commit "[LibOS] Add secure implementation of eventfd" introduced a
post_poll()callback which can be used to trigger additional events on specific events returned from select/poll/epoll. This commit refactors the LibOS code such that sockets-specific handling of EINPROGRESS is moved from select/poll/epoll code into thispost_poll()callback.How to test this PR?
CI must pass.
This change is