Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sgx.require_* manifest options #1863

Merged
merged 1 commit into from
May 3, 2024

Conversation

mkow
Copy link
Member

@mkow mkow commented Apr 29, 2024

Description of the changes

FYI: I'll submit some more cleanups to other deprecated stuff later.

How to test this PR?

CI.


This change is Reviewable

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required) (waiting on @mkow)


-- commits line 2 at r1:
Don't we want a prefix [Docs,PAL/Linux-SGX] ?

Copy link
Member Author

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required) (waiting on @dimakuv)


-- commits line 2 at r1:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Don't we want a prefix [Docs,PAL/Linux-SGX] ?

Or maybe just [PAL/Linux-SGX]? The docs update is just a result of the change in SGX PAL. I can do that when rebasing.

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkow)


-- commits line 2 at r1:

Previously, mkow (Michał Kowalczyk) wrote…

Or maybe just [PAL/Linux-SGX]? The docs update is just a result of the change in SGX PAL. I can do that when rebasing.

Ok, makes sense to me. I'm approving.

Signed-off-by: Michał Kowalczyk <mkow@invisiblethingslab.com>
@mkow mkow force-pushed the mkow/drop-deprecated-stuff branch from 54b0e7b to 60c79e4 Compare May 3, 2024 11:14
Copy link
Member Author

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @dimakuv and @kailun-qin)


-- commits line 2 at r1:

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Ok, makes sense to me. I'm approving.

Done.

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit 60c79e4 into master May 3, 2024
18 checks passed
@dimakuv dimakuv deleted the mkow/drop-deprecated-stuff branch May 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants