[glibc] Fix redefinition of _FORTIFY_SOURCE
#1865
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @oshogbo)
a discussion (no related file):
Please also mention this patch in this list:
subprojects/packagefiles/glibc-2.39/fix-fortify-source.patch line 1 at r1 (raw file):
From 73302ea9454b816d5e0a4f02bbd68df1bf2bb53d Mon Sep 17 00:00:00 2001
I verified this patch to be an exact copy of the one in the Ubuntu Noble patches (bar the differently laid out spaces).
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ), "fixup! " found in commit messages' one-liners (waiting on @dimakuv)
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Please also mention this patch in this list:
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), "fixup! " found in commit messages' one-liners
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners
The new Ubuntu release, Noble, includes a version of GCC with a spec that
defines `_FORTIFY_SOURCE` when optimization is enabled:
```
$ gcc -dumpspecs | grep _FORTIFY_SOURCE
%{!O0:%{O*:%{!D_FORTIFY_SOURCE=*:%{!U_FORTIFY_SOURCE:-D_FORTIFY_SOURCE=3}}}
```
However, some files in glibc need to be built without `_FORTIFY_SOURCE`,
such as `vprintf.c`. The patch from Ubuntu Noble changes the method of
undefining _FORTIFY_SOURCE to -U_FORTIFY_SOURCE. Previously it was limited
only to the preprocessor (-Wp,-U_FORTIFY_SOURCE). The new method also
undefines the definition from the spec.
The patch addresses some other non-standard redefinitions of
_FORTIFY_SOURCE as well.
Signed-off-by: Mariusz Zaborski <oshogbo@invisiblethingslab.com>
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Description of the changes
The new Ubuntu release, Noble, includes a version of GCC with a spec that defines
_FORTIFY_SOURCEwhen optimization is enabled:However, some files in glibc need to be built without
_FORTIFY_SOURCE, such asvprintf.c. The patch from Ubuntu Noble changes the method of undefining _FORTIFY_SOURCE to -U_FORTIFY_SOURCE. Previously it was limited only to the preprocessor (-Wp,-U_FORTIFY_SOURCE). The new method also undefines the definition from the spec.The patch addresses some other non-standard redefinitions of _FORTIFY_SOURCE as well.
Some useful things
Get logs from the ubuntu/debian build (depends on the machine)
Patch obtained from
Ubuntu change log
https://changelogs.ubuntu.com/changelogs/pool/main/g/glibc/glibc_2.39-0ubuntu8.1/changelog
How to test this PR?
Test suite.
This change is