Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common] Refactor Protected Files, part 2 #1867

Merged
merged 1 commit into from
May 7, 2024

Conversation

dimakuv
Copy link
Contributor

@dimakuv dimakuv commented May 2, 2024

Description of the changes

This commit refactors PF code without changing functionality (part 2 in a series of commits). In particular, this commit simplifies function signatures of ipf_read_node() and ipf_write_node().

Extracted from #1841 at the request of @mkow.

How to test this PR?

N/A.


This change is Reviewable

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)


common/src/protected_files/protected_files.c line 847 at r1 (raw file):

        // read the root node of the mht
        if (!ipf_read_node(pf, /*node_number=*/1, &pf->root_mht.encrypted.cipher))
			return false;

tabs

Copy link
Contributor Author

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel), "fixup! " found in commit messages' one-liners (waiting on @mkow)


common/src/protected_files/protected_files.c line 847 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

tabs

Done. I wonder how this could happen.

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), "fixup! " found in commit messages' one-liners

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, "fixup! " found in commit messages' one-liners

This commit refactors PF code without changing functionality (part 2 in
a series of commits). In particular, this commit simplifies function
signatures of `ipf_read_node()` and `ipf_write_node()`.

Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
@dimakuv dimakuv force-pushed the dimakuv/protected-files-cleanup-part2 branch from f6ddd56 to 80377ca Compare May 7, 2024 06:53
Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit 80377ca into master May 7, 2024
18 checks passed
@dimakuv dimakuv deleted the dimakuv/protected-files-cleanup-part2 branch May 7, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants